cordova-docs icon indicating copy to clipboard operation
cordova-docs copied to clipboard

Two corrections to the "Icons" page

Open DAnn2012 opened this issue 2 years ago • 2 comments

Platforms affected

"Icons" page (iOS and Electron)

Motivation and Context

  1. The "density" parameter is for Android not for iOS
  2. The correct value is "app" not "application"

Description

  1. Removed "density" from the example
  2. Corrected from "application" to "app"

Testing

Checklist

  • [ ] I've run the tests to see all new and existing tests pass
  • [ ] I added automated test coverage as appropriate for this change
  • [ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [ ] I've updated the documentation if necessary

DAnn2012 avatar Nov 04 '23 11:11 DAnn2012

Hello @NiklasMerz

When are you planning to review these changes of mine?

Thank you.

DAnn2012 avatar Feb 05 '24 11:02 DAnn2012

Hello @erisu

When are you planning to review these changes of mine?

Thank you.

DAnn2012 avatar Mar 04 '24 22:03 DAnn2012

Hello @breautek

Please could you take a look at this PR of mine?

Thank you.

DAnn2012 avatar Jul 16 '24 08:07 DAnn2012

Thank you, the changes will be live on the dev site in approximately 30 minutes and will appear on the main site next time we "snapshot" the docs.

breautek avatar Jul 16 '24 18:07 breautek