cordova-common icon indicating copy to clipboard operation
cordova-common copied to clipboard

feat: Support finding an unprefixed Info.plist file

Open dpogue opened this issue 1 year ago • 1 comments

Platforms affected

iOS

Motivation and Context

Currently the Info.plist file in a generated iOS project is prefixed with the project name (i.e., HelloCordova-Info.plist), and plugins have to set up their config-file/edit-config directives to use wildcards like **/*-Info.plist.

The standard way for Xcode projects is to just have Info.plist in the project, and this gets us one step closer to supporting that.

Description

  • Try to find an unprefixed Info.plist, falling back to the AppName-Info.plist
  • Cache the result of the Xcodeproj name to avoid repeated globs
  • Streamline plist loading to avoid reading the file twice
    • This allows us to drop the read-chunks dependency in next major

Testing

Added a new test for the Info.plist behaviour. All existing tests pass.

Checklist

  • [x] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change

dpogue avatar Aug 23 '24 16:08 dpogue