cordova-cli icon indicating copy to clipboard operation
cordova-cli copied to clipboard

Update `create` doc with proper default values

Open ath0mas opened this issue 4 years ago • 2 comments

Platforms affected

Docs

Motivation and Context

Mixed default values for create between cli doc, cordova-android and cordova-ios.

Description

After reviewing the various values used in cordova-android and cordova-ios for create here are my suggested proper defaults:

  • id / package name: io.cordova.helloCordova
  • name / project name: Hello Cordova

These are the most common values already used but not always ; see linked PRs to fix this situation (apache/cordova-ios#1100, apache/cordova-android#1213).

Testing

in cordova-android and cordova-ios respectively

Checklist

  • [ ] I've run the tests to see all new and existing tests pass
  • [x] I added automated test coverage as appropriate for this change
  • [x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [x] I've updated the documentation if necessary

ath0mas avatar Apr 18 '21 20:04 ath0mas

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ad7fd5d). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #554   +/-   ##
=========================================
  Coverage          ?   70.40%           
=========================================
  Files             ?        4           
  Lines             ?      321           
  Branches          ?        0           
=========================================
  Hits              ?      226           
  Misses            ?       95           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad7fd5d...049daaa. Read the comment docs.

codecov-commenter avatar Apr 18 '21 20:04 codecov-commenter

@NiklasMerz you are right :/ I looked for create values in cli, android and ios but it seems I missed the template is elsewhere... like in cordova-lib and or cordova-create ... ; I'm on it.

ath0mas avatar Sep 19 '21 19:09 ath0mas