cordova-cli icon indicating copy to clipboard operation
cordova-cli copied to clipboard

update readme.md with buildConfig detail

Open hiepxanh opened this issue 6 years ago • 7 comments

Platforms affected

android, ios, browser

What does this PR do?

just update readme to clarify that have ~ can realate to HOME path enviroment variable

What testing has been done on this change?

Checklist

  • [ ] Reported an issue in the JIRA database
  • [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • [ ] Added automated test coverage as appropriate for this change.

hiepxanh avatar Nov 16 '18 10:11 hiepxanh

Why is this so relevant here that it should explicitly be mentioned? There are loads of other possible ENV variables that can point to all kinds of interesting folders. We don't mention those here either.

Related: https://github.com/apache/cordova-docs/pull/909

janpio avatar Nov 16 '18 11:11 janpio

I already answer on this topic sir, [fix] better support for window, sorry for copy text have cap . Let discussion about this.

hiepxanh avatar Nov 18 '18 14:11 hiepxanh

Thanks @hiepxanh for pointing it out and proposing the idea. I have some doubts, though.

This seems to be specific to the Android platform, and from https://github.com/apache/cordova-android/pull/563#issuecomment-439701558, and I would agree with https://github.com/apache/cordova-android/pull/563#issuecomment-439701558 that this may not what we want to support in the future.

Another thing is that I think ~ is not universally supported on Windows cmd shell (not sure though).

I think we should look for a way to support specifying a path based on the home directory in a way that works consistently across all Cordova platforms and all development systems, and get it documented if we fix it.

I recommend that you raise a single issue in https://github.com/apache/cordova/issues to explain the situation and propose one or more alternative solutions for discussion.

P.S. I would also appreciate it if people would avoid using words with "all caps", even in a link, since it is generally interpreted as a form of shouting. I would recommend that you consider wrapping the text with ** on both sides to emphasize it in bold, works for links as well. Some recommended reading is here.

brody4hire avatar Nov 18 '18 16:11 brody4hire

Thanks @brodybits for ignoring the explicit wish of @hiepxanh to discuss this in the PR and with that splitting the discussion to several places. A lot more impolite than using all caps in a harmless link that from context alone clearly is not shouting.

janpio avatar Nov 18 '18 17:11 janpio

@hiepxanh @janpio @raphinesse I am fine to discuss approach and solution here, https://github.com/apache/cordova-android/pull/563, https://github.com/apache/cordova-cli/pull/359, or wherever else you guys want to discuss it. I would favor using untildify as suggested in https://github.com/apache/cordova-android/pull/563#issuecomment-439709919, and I would like to see a similar solution applied to all platforms as discussed in https://github.com/apache/cordova-android/pull/563. My comments are my opinions, please feel free to agree or disagree as you like.

brody4hire avatar Nov 18 '18 18:11 brody4hire

I'm so sorry @janpio @brodybits, I don't mean to shout or impolite, sorry for my unintended action. I just copy that title text and it have with cap. I was fix it. and I agree with sir @brodybits that solution to use untildify. it will be very helpful. My suggest is just an template solution when I see that no way to this. I'm very happy to that member concern about this and discuss with me. Should I close this issue if we will have an other solution soon?

hiepxanh avatar Nov 18 '18 23:11 hiepxanh

I created https://github.com/apache/cordova/issues/48 as a proper discussion issue about this. I hope I got everything.

janpio avatar Nov 18 '18 23:11 janpio