cordova-cli icon indicating copy to clipboard operation
cordova-cli copied to clipboard

`cordova plugin remove` not cleaning `<js-module />` changes.

Open Jule- opened this issue 5 years ago • 0 comments

Don't know if it is a limitation or a lack of dependency tracking but:

cordova create plugtestapp-a com.test.plugtestapp PlugTestApp \
&& cd plugtestapp-a/ \
&& cordova platform add [email protected] \
&& cd .. \
&& cordova create plugtestapp-b com.test.plugtestapp PlugTestApp \
&& cd plugtestapp-b/ \
&& cordova plugin add cordova-plugin-local-notification \
&& cordova platform add [email protected] \
&& cordova plugin remove cordova-plugin-local-notification \
&& cd .. \
&& diff --recursive plugtestapp-a plugtestapp-b

Residual data in:

diff plugtestapp-a/platforms/android/platform_www/cordova_plugins.js plugtestapp-b/platforms/android/platform_www/cordova_plugins.js
diff plugtestapp-a/plugins/fetch.json plugtestapp-b/plugins/fetch.json

Don't know if it can cause issues on prepared platform while removing plugin with this but I think it could. And developers are not prepared! At least the documentation should warn developers in order to always make a clean platform prepare before shipping release.

Jule- avatar Oct 23 '18 18:10 Jule-