cordova-browser icon indicating copy to clipboard operation
cordova-browser copied to clipboard

Inline browser_parser into Api

Open raphinesse opened this issue 5 years ago • 1 comments

Motivation and Context

Reduce (unused) code.

Description

  • Remove unused stuff from browser_parser
  • Inline remaining two methods from browser_parser into Api

This removes the property parser from Api instances. AFAIK this prop is not documented, so I'd consider it private. But if we would consider it public, this PR would be a major change.

Testing

I ran npm t

raphinesse avatar Jun 03 '20 13:06 raphinesse

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16271b4...d3d9328. Read the comment docs.

codecov-commenter avatar Jun 03 '20 15:06 codecov-commenter