commons-validator icon indicating copy to clipboard operation
commons-validator copied to clipboard

Adding new contries to IBAN list

Open tatiana-scda opened this issue 3 years ago • 5 comments

The list has been updated in 2022. Reference: https://www.iso13616.org/

Under the file iban-registery, we can see the following missing countries and their IBANs, added into the tests:

image

image

image

image

tatiana-scda avatar Oct 07 '22 09:10 tatiana-scda

@tatiana-scda You must have not run the tests as this PR fails the build. Run mvn before pushing a PR please.

garydgregory avatar Oct 07 '22 20:10 garydgregory

@garydgregory Locally validated, should be okay now

tatiana-scda avatar Oct 10 '22 08:10 tatiana-scda

hey @garydgregory can we retry the workflows?

tatiana-scda avatar Oct 17 '22 10:10 tatiana-scda

@tatiana-scda Rebase on master and push.

garydgregory avatar Oct 17 '22 12:10 garydgregory

@garydgregory already up to date 👍🏿

tatiana-scda avatar Oct 17 '22 15:10 tatiana-scda

Hi @tatiana-scda Please rebase on git master and check what might still be missing. TY!

garydgregory avatar Jan 08 '23 14:01 garydgregory

@tatiana-scda FYI, I resolved the conflict.

garydgregory avatar Jan 16 '23 16:01 garydgregory