commons-lang icon indicating copy to clipboard operation
commons-lang copied to clipboard

Remove unnecessary conditions. It's no need it after assigns tmp to duration

Open arturobernalg opened this issue 3 years ago • 1 comments

We don't need that conditions. Its always false and will never reach it. And just because in the line 192 we assigns tmp to duration.

arturobernalg avatar Oct 08 '22 19:10 arturobernalg

Codecov Report

Merging #965 (16cc08f) into master (b6d39a4) will increase coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #965      +/-   ##
============================================
+ Coverage     91.99%   92.01%   +0.01%     
- Complexity     7432     7433       +1     
============================================
  Files           189      189              
  Lines         15664    15662       -2     
  Branches       2907     2906       -1     
============================================
+ Hits          14410    14411       +1     
+ Misses          677      676       -1     
+ Partials        577      575       -2     
Impacted Files Coverage Δ
...apache/commons/lang3/time/DurationFormatUtils.java 91.10% <ø> (+0.76%) :arrow_up:
...ommons/lang3/concurrent/AtomicSafeInitializer.java 100.00% <0.00%> (+14.28%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 08 '22 21:10 codecov-commenter