commons-lang icon indicating copy to clipboard operation
commons-lang copied to clipboard

LANG-1369: Formatted and Paramaterized Exception Classes

Open belugabehr opened this issue 6 years ago • 1 comments

belugabehr avatar Mar 19 '19 18:03 belugabehr

Would you please be so kind, and suggest a use case, which your pr is going to address. Cause, I don't see it immediately.

Also a suggestion: Out in the wild, there are quite a number of Pattern format styles, including, for example

Hi, guys, my name is {}.

Hi, guys, my name is %s.

Hi, guys, my name is %1.

(Sure, a bit of digging would reveal others.) So, I would suggest, that

  1. You replace the PatternFormatter with an interface, and a default implementation.
  2. You replace the static ExceptionFactory with instance methods, that use a configurable instance. The static methods might be reimplemented using an instance of the default implementation.

jochenw avatar Mar 25 '19 16:03 jochenw