Move combine.children to manifestEntries in order to have right entries in MANIFEST.MF

Open kinow opened this issue 7 years ago • 1 comments

Hi,

While working on Commons Imaging 1.0-alpha release candidate, I noticed that after copying most of the entries missing from Commons Lang's pom.xml, I couldn't pass the step that asks to check for X-Compile-Source-JDK in MANIFEST.MF .

After some troubleshooting (and updating my Maven for the just-in-case), I realized that the combine.child seemed to result in manifestEntries child node being replaced.

But moving the combine.child to the manifestEntries made more sense, as that's the key that we want Maven to append parent+child.

Tested locally in Commons Imaging, and also in Commons Lang. After this change, I can successfully see the entries in the Lang's new MANIFEST.MF generated locally.

...
Bundle-Version: 3.9.0.SNAPSHOT
X-Compile-Target-JDK: 1.8
Implementation-Build: master@r6dc3a6db11d7e63c960ccc6cf48aa15d6f00e903
 ; 2018-09-08 10:35:11+0000
X-Compile-Source-JDK: 1.8
Created-By: Apache Maven Bundle Plugin
Build-Jdk: 1.8.0_181
...

Cheers Bruno

Sep 08 '18 10:09 kinow

Coverage remained the same at 95.253% when pulling 790655c1f82645d48a53456388304bf754d5470e on kinow:fix-manifest-entries into 6dc3a6db11d7e63c960ccc6cf48aa15d6f00e903 on apache:master.

Sep 08 '18 11:09 coveralls