commons-io icon indicating copy to clipboard operation
commons-io copied to clipboard

Add new function: byteCountToDisplayRoundedSize

Open zsoltii opened this issue 6 years ago • 3 comments

Commons IO/IO-373

https://issues.apache.org/jira/browse/IO-373

zsoltii avatar Mar 01 '19 09:03 zsoltii

Coverage Status

Coverage increased (+0.1%) to 88.461% when pulling 038083ca01b2647d7a4f554cb2cc13a06466e33c on zsoltii:master into 2fc42360f6f59c2f9d8743eb5628fe137ff6e4cc on apache:master.

coveralls avatar Mar 01 '19 10:03 coveralls

Would love this feature!

zkendall avatar Jul 12 '19 23:07 zkendall

PR not in last release 2.11.0, when will the change be provided?

rainermueller avatar Jan 05 '22 16:01 rainermueller

@zsoltii your solution looks pretty cool. Could you resolve conflics, or are you OK if I take over the PR and resolve them?

RockyMM avatar Nov 09 '22 19:11 RockyMM

I do not think number-text conversion routines belong in Commons IO. Maybe in Commons Text?

garydgregory avatar Nov 09 '22 20:11 garydgregory

@garydgregory I think this is more about byte/bit display handling. Another perspective is that the migration to Commons Text a bit extending the scope. This is about improving the current function, which has its drawbacks, with a better implementation. Once we have this, the function could be migrated to Commons Text if all stakeholders agree.

RockyMM avatar Nov 14 '22 09:11 RockyMM

Hello @zsoltii My main point is that the functionality should not have been put here in the first place, it has nothing to do with IO; consequently, let's not make it bigger.

garydgregory avatar Nov 14 '22 12:11 garydgregory

Hey @garydgregory,

On a second thought, you do have a point.

Then I would suggest we move the functionality to CommonsText, and create an issue that will mark all of these methods as @Deprecated.

RockyMM avatar Nov 16 '22 10:11 RockyMM

Hi @RockyMM Go for it ;-)

garydgregory avatar Nov 16 '22 11:11 garydgregory