commons-io icon indicating copy to clipboard operation
commons-io copied to clipboard

Makes Tailer use ScheduledExecutorService from Java 5

Open triceo opened this issue 11 years ago • 4 comments

This has multiple benefits:

  • it provides periodic runs of the read operations without needing to invoke Thread.sleep().
  • it removes any looping from the run() method, making for cleaner code.
  • generally brings Tailer closer to what modern Java looks like.

No public API changes have been made. All tests are passing without modifications.

triceo avatar May 17 '14 15:05 triceo

@triceo May you rebase on master?

garydgregory avatar Jul 11 '21 17:07 garydgregory

@triceo May you plerase rebase on master? The implementation has changed to use the builder pattern with an internal Duration instead of long to track the sleep delay. It looks like the code needs to be adapted to configure the builder with an executor.

garydgregory avatar Sep 23 '21 15:09 garydgregory

@garydgregory I may eventually get to it, but considering that the original PR is from 2014, I have moved on.

triceo avatar Sep 23 '21 17:09 triceo

Either it's useful or not, regardless of your moving about 😉

garydgregory avatar Sep 23 '21 17:09 garydgregory