commons-email icon indicating copy to clipboard operation
commons-email copied to clipboard

upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail)

Open gitmotte opened this issue 4 years ago • 5 comments

precondition https://github.com/davidmoten/subethasmtp/pull/37

  • #28
  • #35
  • #24
  • push version of commons-email to 2.0.0 (breaking change)

gitmotte avatar Jan 19 '21 16:01 gitmotte

@garydgregory , hello, do you accidentally know why this PR was not merged? Current 1.x commons-email uses old javax.mail and it's hard to switch to jakarta.mail as one lib (e.g. subethamail) depends on another and so on. I see that in e0cf5b65f5034f5486592876dcb72fc2c9d166ca you've updated jakarta.mail but I assume those changes were never released.

KroArtem avatar Jun 08 '22 12:06 KroArtem

  1. the build fails and 2) we are all volunteers here.

garydgregory avatar Jun 08 '22 16:06 garydgregory

I'll update the GH build to only use LTS versions...

garydgregory avatar Jun 08 '22 16:06 garydgregory

Hm, looks like this branch needs a rebase.

garydgregory avatar Jun 08 '22 16:06 garydgregory

the build fails and 2) we are all volunteers here.

Sure, no pressure here, just wanted to know whether there was an objective reason not to merge it.

As I see the situation, it's a breaking change and major version update is required.

KroArtem avatar Jun 08 '22 19:06 KroArtem

@gitmotte This PR needs a rebase so we can see what all the various checks say.

garydgregory avatar Nov 12 '22 19:11 garydgregory

Based on discussions in my PR (linked above) this PR needs to be closed...

KroArtem avatar Nov 13 '22 09:11 KroArtem

looking forward to this one, unfortunately the logs for the failing builds are not available anymore

Loki-Afro avatar Dec 08 '22 10:12 Loki-Afro

To anybody interested, I created #133 as a replacement for this PR.

reda-alaoui avatar Jan 21 '23 22:01 reda-alaoui

Closing: See https://issues.apache.org/jira/projects/EMAIL/issues/EMAIL-203?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC

garydgregory avatar Dec 15 '23 15:12 garydgregory