commons-email icon indicating copy to clipboard operation
commons-email copied to clipboard
verified publisher icon apache

EMAIL-163 Support for OAuth2 authentication

Open sgoeschl opened this issue 7 months ago • 4 comments

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • [X] Read the contribution guidelines for this project.
  • [X] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • [X] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

sgoeschl avatar May 27 '25 19:05 sgoeschl

@garydgregory Merged your changes and resolved all issues

sgoeschl avatar May 29 '25 08:05 sgoeschl

@garydgregory Reminder, thank you 😅

mkomko avatar Jul 04 '25 06:07 mkomko

@garydgregory Are you happy with the PR?

sgoeschl avatar Jul 24 '25 15:07 sgoeschl

Hi everyone,

I just wanted to bring this PR back into focus, as it seems to be stuck. The functionality here is (IMHO) quite important for users, and leaving it unmerged might risk discouraging adoption or pushing people away who rely on this feature.

From what I can see, the change is essentially just forwarding a parameter to Jakarta Mail. That’s a very low-risk adjustment, and while of course thorough tests are always valuable, in this specific case the cost–benefit trade-off of waiting for a full test suite may not justify the delay. I'm not sure @sgoeschl is prepared to invest this kind of time, since he is no longer really active.

Would it be possible to merge this with at least a minimal test that checks whether the parameter has been set (or even with a clear TODO for additional tests), so that the community can start benefiting from it? Alternatively, maybe a committer or contributor closer to the project could help add the tests, if they are considered strictly necessary.

This way the feature doesn’t stay blocked, users get what they need, and the code quality expectations of the project can still be met in a collaborative way.

What do you think?

mkomko avatar Oct 01 '25 07:10 mkomko