commons-crypto icon indicating copy to clipboard operation
commons-crypto copied to clipboard

CRYPTO-161 Add SM4 encryption support

Open wenwj0 opened this issue 3 years ago • 6 comments

add sm4-ctr and sm4-cbc in opensslCipher

wenwj0 avatar Jun 09 '22 11:06 wenwj0

Hi,

I am interested in the work, that you are doing here. Question: I notice, that your patch provides changes in the native code. That makes me hesitant: Before I accept the PR, could you help me to setup a build environment, where I can test these changes.

Background: We are considering a new release. As of now, there are no changes in the native code, so we could (in theory) just copy the native files from the previous release. But, for a release, that includes this PR, we would need a running build environment, where we can produce the updated files.

If this is interesting to you, please contact me privately at [email protected].

Thanks,

Jochen

jochenw avatar Jun 09 '22 12:06 jochenw

https://issues.apache.org/jira/browse/CRYPTO-161

garydgregory avatar Jun 09 '22 14:06 garydgregory

We really need to update our GitHub build to deal with the C sources...

garydgregory avatar Jun 09 '22 14:06 garydgregory

We need to be able to tell GitHub builds that we need OpenSSL >= 1.1.1

garydgregory avatar Jun 09 '22 17:06 garydgregory

I found a warning in Java CI / build (macos-latest, 8, false): ** WARN: Could not enable JNA; detected lib VERSION 0x10000000: Error looking up function 'ENGINE_load_rdrand': dlsym(0x7ff81e7bd070, ENGINE_load_rdrand): symbol not found

Maybe the OpenSSL in Github builds is 1.0.0

wenwj0 avatar Jun 10 '22 02:06 wenwj0

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

codecov-commenter avatar Nov 14 '23 17:11 codecov-commenter