commons-collections icon indicating copy to clipboard operation
commons-collections copied to clipboard

COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE

Open angusdev opened this issue 2 years ago • 2 comments

COLLECTIONS-814 CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty

Add null check in ListUtil.removeAll()

angusdev avatar Sep 24 '22 20:09 angusdev

Codecov Report

Merging #340 (dc007a1) into master (474713f) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #340      +/-   ##
============================================
+ Coverage     85.93%   85.98%   +0.05%     
- Complexity     4669     4671       +2     
============================================
  Files           289      289              
  Lines         13445    13447       +2     
  Branches       1977     1977              
============================================
+ Hits          11554    11563       +9     
+ Misses         1327     1323       -4     
+ Partials        564      561       -3     
Impacted Files Coverage Δ
...ava/org/apache/commons/collections4/ListUtils.java 87.30% <100.00%> (+0.20%) :arrow_up:
...commons/collections4/map/AbstractReferenceMap.java 91.48% <0.00%> (+2.59%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 24 '22 20:09 codecov-commenter

ping?

angusdev avatar Oct 18 '22 06:10 angusdev

Merged. Thanks @angusdev !

kinow avatar Oct 19 '22 02:10 kinow