commons-beanutils icon indicating copy to clipboard operation
commons-beanutils copied to clipboard

Spotless Formatter and License Header Check

Open melloware opened this issue 5 years ago • 3 comments
trafficstars

Eclipse formatter which follows all the CheckStyle and Apache Commons guidelines for formatting. 4 Spaces, 120 line limit, proper whitespace handling etc.

Window->Preferences->Java->Code Style->Formatter and then press the Import button.

Point to eclipse-apache-formatter.xml.

You can format the entire project in one shot by right clicking on the package org.apache.commons.beanutils2 and selecting Source->Format.

OR...

Run mvn spotless:check or mvn spotless:apply to either format code or validate the format.

@aherbert I turned OFF all Javadoc formatting and now this looks much better. its not perfect but I don't know if there is a perfect formatter out there. This is to get the project in a good starting state for 2.0.0 release.

melloware avatar Sep 08 '20 18:09 melloware

The pom.xml formatting was a mess. I have reformatted it in master to remove tabs and use 2 spaces for the indent. Can you rebase so only the changes you have made show up in the diffs?

aherbert avatar Sep 08 '20 18:09 aherbert

Yeah it was a mess that is why I formatted it for 4 spaces which I thought was Apache standard?

melloware avatar Sep 08 '20 18:09 melloware

OK pom.xml has been fixed.

melloware avatar Sep 08 '20 18:09 melloware