commons-bcel icon indicating copy to clipboard operation
commons-bcel copied to clipboard

Don't update mockito major version

Open raboof opened this issue 11 months ago • 7 comments

Mockito 5 uses Java 11

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • [ ] Read the contribution guidelines for this project.
  • [ ] Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

raboof avatar Dec 30 '24 11:12 raboof

Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT?

garydgregory avatar Dec 30 '24 13:12 garydgregory

Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT?

It seems to be pretty widely used, so I guess that would make sense?

raboof avatar Dec 30 '24 13:12 raboof

I don't think we need this change since commons-parent will define the Mockito version when the next version is released later today.

garydgregory avatar Jan 06 '25 12:01 garydgregory

I agree (though we should replace it with a PR that uses the mockito version from the parent pom)

raboof avatar Jan 06 '25 12:01 raboof

Hi @raboof Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references. In the meantime, would you help review the other Commons release candidates?

  • Codec: https://lists.apache.org/thread/66fvglm37rgt4hc8wzz6q3p5syctj1pf
  • BeanUtils 1: https://lists.apache.org/thread/g1xtov6k6w4ms2sb588f51z4y17dynz6
  • TY you for review on BeanUtils 2 😄

garydgregory avatar Jan 06 '25 12:01 garydgregory

Hi @raboof Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references.

:+1:

In the meantime, would you help review the other Commons release candidates?

* Codec: https://lists.apache.org/thread/66fvglm37rgt4hc8wzz6q3p5syctj1pf

will do

* BeanUtils 1: https://lists.apache.org/thread/g1xtov6k6w4ms2sb588f51z4y17dynz6

https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?

raboof avatar Jan 06 '25 12:01 raboof

https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?

You're right, fixing... fixed: Committed revision 73999. I'll update the vote email with this revision number.

garydgregory avatar Jan 06 '25 12:01 garydgregory