cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

set `displayName` to `name` by default

Open DaanHoogland opened this issue 1 year ago • 9 comments

Description

This PR prevents a null display name on VMs (see https://github.com/apache/cloudstack/pull/8503#issuecomment-2367394302)

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland avatar Sep 23 '24 07:09 DaanHoogland

@blueorangutan package

DaanHoogland avatar Sep 23 '24 07:09 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 23 '24 07:09 blueorangutan

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.00%. Comparing base (e4414d1) to head (96988ea).

:exclamation: There is a different number of reports uploaded between BASE (e4414d1) and HEAD (96988ea). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e4414d1) HEAD (96988ea)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #9719       +/-   ##
============================================
- Coverage     16.18%   4.00%   -12.18%     
============================================
  Files          5657     402     -5255     
  Lines        498478   32668   -465810     
  Branches      60501    5810    -54691     
============================================
- Hits          80668    1309    -79359     
+ Misses       408827   31204   -377623     
+ Partials       8983     155     -8828     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 23 '24 08:09 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11176

blueorangutan avatar Sep 23 '24 08:09 blueorangutan

@DaanHoogland it looks like an UI issue

the API response does have the "displayname" in place. but the name/displayname is not displayed on UI.

as a simple workaround, can we revert #8503 ? @DaanHoogland

weizhouapache avatar Sep 23 '24 08:09 weizhouapache

as a simple workaround, can we revert #8503 ? @DaanHoogland

yes, you are right, I'll creat another PR, reapply the changes here, and work on this later.

DaanHoogland avatar Sep 23 '24 08:09 DaanHoogland

@blueorangutan ui

weizhouapache avatar Sep 23 '24 08:09 weizhouapache

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Sep 23 '24 08:09 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9719 (QA-JID-456)

blueorangutan avatar Sep 23 '24 08:09 blueorangutan