cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard
verified publisher icon apache

NAS B&R Plugin enhancements

Open Pearl1594 opened this issue 1 year ago • 41 comments

Description

This PR fixes small issues and adds minor improvements to the NAS B&R Plugin

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 avatar Sep 10 '24 17:09 Pearl1594

@blueorangutan package

Pearl1594 avatar Sep 10 '24 17:09 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 10 '24 17:09 blueorangutan

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 15.98%. Comparing base (5aa79a6) to head (9714aae). Report is 69 commits behind head on 4.20.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 24 Missing :warning:
...ce/wrapper/LibvirtRestoreBackupCommandWrapper.java 0.00% 13 Missing :warning:
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 10 Missing :warning:
...rg/apache/cloudstack/backup/NASBackupProvider.java 0.00% 6 Missing :warning:
.../actionworkers/KubernetesClusterDestroyWorker.java 0.00% 3 Missing :warning:
...i/command/user/backup/DeleteBackupScheduleCmd.java 0.00% 2 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20    #9666      +/-   ##
============================================
- Coverage     15.99%   15.98%   -0.02%     
- Complexity    13060    13084      +24     
============================================
  Files          5644     5649       +5     
  Lines        494915   495747     +832     
  Branches      59960    60029      +69     
============================================
+ Hits          79173    79254      +81     
- Misses       406910   407640     +730     
- Partials       8832     8853      +21
Flag Coverage Δ
uitests 4.01% <ø> (-0.01%) :arrow_down:
unittests 16.82% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 10 '24 17:09 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11085

blueorangutan avatar Sep 10 '24 18:09 blueorangutan

This looks like a bug fix on a new feature @Pearl1594 , should it go in 4.20? cc @JoaoJandre

DaanHoogland avatar Sep 11 '24 07:09 DaanHoogland

This isn't targeted for 4.20 @DaanHoogland. This PR is to improve aspects of the recently merged changes. There will be more changes added to this PR.

Pearl1594 avatar Sep 11 '24 11:09 Pearl1594

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Sep 20 '24 14:09 github-actions[bot]

@blueorangutan package

Pearl1594 avatar Sep 23 '24 14:09 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 23 '24 14:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11180

blueorangutan avatar Sep 23 '24 15:09 blueorangutan

@blueorangutan test

Pearl1594 avatar Sep 24 '24 15:09 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Sep 24 '24 15:09 blueorangutan

[SF] Trillian test result (tid-11544) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57781 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9666-t11544-kvm-ol8.zip Smoke tests completed. 122 look OK, 1 have errors, 18 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
all_test_vm_autoscaling Skipped --- test_vm_autoscaling.py
all_test_vm_deployment_planner Skipped --- test_vm_deployment_planner.py
all_test_vm_life_cycle Skipped --- test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import Skipped --- test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule Skipped --- test_vm_schedule.py
all_test_vm_snapshot_kvm Skipped --- test_vm_snapshot_kvm.py
all_test_vm_snapshots Skipped --- test_vm_snapshots.py
all_test_vm_strict_host_tags Skipped --- test_vm_strict_host_tags.py
all_test_vnf_templates Skipped --- test_vnf_templates.py
all_test_volumes Skipped --- test_volumes.py
all_test_vpc_ipv6 Skipped --- test_vpc_ipv6.py
all_test_vpc_redundant Skipped --- test_vpc_redundant.py
all_test_vpc_router_nics Skipped --- test_vpc_router_nics.py
all_test_vpc_vpn Skipped --- test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py
all_test_hostha_kvm Skipped --- test_hostha_kvm.py

blueorangutan avatar Sep 25 '24 08:09 blueorangutan

[SF] Trillian Build Failed (tid-11557)

blueorangutan avatar Sep 27 '24 07:09 blueorangutan

@blueorangutan test

Pearl1594 avatar Sep 27 '24 13:09 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Sep 27 '24 13:09 blueorangutan

[SF] Trillian test result (tid-11567) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 74347 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9666-t11567-kvm-ol8.zip Smoke tests completed. 131 look OK, 2 have errors, 8 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestLBRuleUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestPublicIPUsage>:teardown Error 706.05 test_usage.py
ContextSuite context=TestSnapshotUsage>:setup Error 836.49 test_usage.py
ContextSuite context=TestTemplateUsage>:setup Error 908.92 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 1431.36 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 1587.24 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 1675.28 test_usage.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestSecuredVmMigration>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 0.00 test_vm_life_cycle.py
all_test_vm_autoscaling Skipped --- test_vm_autoscaling.py
all_test_vm_deployment_planner Skipped --- test_vm_deployment_planner.py
all_test_vm_lifecycle_unmanage_import Skipped --- test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule Skipped --- test_vm_schedule.py
all_test_vm_snapshot_kvm Skipped --- test_vm_snapshot_kvm.py
all_test_vm_snapshots Skipped --- test_vm_snapshots.py
all_test_vm_strict_host_tags Skipped --- test_vm_strict_host_tags.py
all_test_vnf_templates Skipped --- test_vnf_templates.py

blueorangutan avatar Sep 28 '24 10:09 blueorangutan

[SF] Trillian Build Failed (tid-11573)

blueorangutan avatar Sep 30 '24 07:09 blueorangutan

[SF] Trillian Build Failed (tid-11574)

blueorangutan avatar Sep 30 '24 07:09 blueorangutan

[SF] Trillian Build Failed (tid-11575)

blueorangutan avatar Sep 30 '24 07:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Oct 01 '24 04:10 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 01 '24 04:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11248

blueorangutan avatar Oct 01 '24 05:10 blueorangutan

@blueorangutan package

rajujith avatar Oct 04 '24 04:10 rajujith

@blueorangutan package

rajujith avatar Oct 07 '24 08:10 rajujith

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 07 '24 08:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11292

blueorangutan avatar Oct 07 '24 09:10 blueorangutan

@blueorangutan package

Pearl1594 avatar Oct 08 '24 01:10 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 08 '24 01:10 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11299

blueorangutan avatar Oct 08 '24 02:10 blueorangutan