cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard
verified publisher icon apache

[VMware] Add support for VMware 8.0u2 (8.0.2.x) and 8.0u3 (8.0.3.x)

Open sureshanaparti opened this issue 1 year ago • 5 comments

Description

This PR adds support for VMware 8.0u2 (8.0.2.x) and 8.0u3 (8.0.3.x).

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [x] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti avatar Aug 27 '24 06:08 sureshanaparti

@blueorangutan package

sureshanaparti avatar Aug 27 '24 06:08 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 27 '24 06:08 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.57%. Comparing base (a5f5560) to head (7f84a03). Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #9591    +/-   ##
==========================================
  Coverage     15.57%   15.57%            
- Complexity    12047    12052     +5     
==========================================
  Files          5505     5505            
  Lines        482621   482738   +117     
  Branches      61174    61629   +455     
==========================================
+ Hits          75176    75202    +26     
- Misses       399141   399226    +85     
- Partials       8304     8310     +6
Flag Coverage Δ
uitests 4.17% <ø> (+<0.01%) :arrow_up:
unittests 16.35% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 06:08 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10819

blueorangutan avatar Aug 27 '24 07:08 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Aug 27 '24 22:08 github-actions[bot]

@blueorangutan package

sureshanaparti avatar Sep 02 '24 09:09 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 02 '24 10:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10907

blueorangutan avatar Sep 02 '24 10:09 blueorangutan

@blueorangutan package

sureshanaparti avatar Sep 02 '24 12:09 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 02 '24 12:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10910

blueorangutan avatar Sep 02 '24 13:09 blueorangutan

[SF] Trillian Build Failed (tid-11299)

blueorangutan avatar Sep 02 '24 20:09 blueorangutan

systemvmtemplate Jenkins build kicked, template available in next 30mins at https://build.yadav.cloud/systemvm/

rohityadavcloud avatar Sep 03 '24 10:09 rohityadavcloud

@blueorangutan package

rohityadavcloud avatar Sep 04 '24 06:09 rohityadavcloud

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 04 '24 06:09 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 10941

blueorangutan avatar Sep 04 '24 07:09 blueorangutan

@blueorangutan package

rohityadavcloud avatar Sep 04 '24 09:09 rohityadavcloud

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 04 '24 09:09 blueorangutan

Systemvmtemplate build OK https://build.yadav.cloud/systemvm/9591-x86_64/

rohityadavcloud avatar Sep 04 '24 10:09 rohityadavcloud

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10955

blueorangutan avatar Sep 04 '24 11:09 blueorangutan

@blueorangutan package

sureshanaparti avatar Sep 04 '24 11:09 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 04 '24 11:09 blueorangutan

@blueorangutan help

sureshanaparti avatar Sep 04 '24 12:09 sureshanaparti

@sureshanaparti [SL] I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups] Mgmt OS options: ['ol8', 'ol9', 'alma8', 'alma9', 'suse15', 'centos7', 'centos6', 'rocky8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82'] Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command. when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu. When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced) Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar']

blueorangutan avatar Sep 04 '24 12:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10958

blueorangutan avatar Sep 04 '24 12:09 blueorangutan

@blueorangutan test ol8 vmware-80u2

DaanHoogland avatar Sep 04 '24 17:09 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u2) has been kicked to run smoke tests

blueorangutan avatar Sep 04 '24 17:09 blueorangutan

Smoketests wouldn't do justice as new systemvmtemplate hasn't been uploaded yet. Merging this based on code reviews and manual tests, will kick tests on health check PR - after building/replacing the new systemvmtemplates.

rohityadavcloud avatar Sep 05 '24 03:09 rohityadavcloud

[SF] Trillian test result (tid-11352) Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57766 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9591-t11352-vmware-80u3.zip Smoke tests completed. 100 look OK, 30 have errors, 9 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 5.26 test_diagnostics.py
test_04_list_domains_level_filter Failure 0.07 test_list_domains.py
test_05_list_domains_no_filter Failure 0.04 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.05 test_list_volumes.py
test_07_list_volumes_listall Failure 0.05 test_list_volumes.py
test_reboot_router Error 424.32 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Error 15.20 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Error 67.14 test_network.py
test_01_deployVMInSharedNetwork Error 242.52 test_network.py
test_01_add_primary_storage_disabled_host Error 0.34 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 163.45 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.14 test_primary_storage_scope.py
test_02_vpc_privategw_static_routes Failure 207.37 test_privategw_acl.py
test_02_vpc_privategw_static_routes Error 207.38 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 208.80 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Error 208.81 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 364.18 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Error 364.19 test_privategw_acl.py
test_09_project_suspend Error 95.15 test_projects.py
test_deploy_vm_with_registered_userdata Error 111.07 test_register_userdata.py
test_deploy_vm_with_registered_userdata Error 111.08 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 102.68 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 102.69 test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
test_01_so_removal_resource_update Error 109.12 test_resource_accounting.py
test_01_restore_vm Error 31.26 test_restore_vm.py
test_02_restore_vm_with_disk_offering Error 72.87 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 30.39 test_restore_vm.py
test_04_restore_vm_allocated_root Error 33.70 test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown Error 51.46 test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py
test_02_routervm_iptables_policies Error 114.98 test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies Error 134.85 test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies Error 134.86 test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true Error 114.04 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Error 89.42 test_routers_network_ops.py
test_03_RVR_Network_check_router_state Error 201.27 test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
test_01_scale_vm Error 1.51 test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling Error 1.46 test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling Error 1.39 test_scale_vm.py
test_04_scale_vm_with_user_account Error 9.19 test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change Error 1.56 test_scale_vm.py
test_01_sys_vm_start Failure 0.11 test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup Error 10.35 test_service_offerings.py
test_03_create_vpc_with_specified_source_nat_ip_address Error 1.21 test_set_sourcenat.py
test_04_change_source_nat_ip_address_for_vpc Error 1.26 test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup Error 0.00 test_snapshots.py
test_01_list_sec_storage_vm Failure 0.05 test_ssvm.py
test_02_list_cpvm_vm Failure 0.05 test_ssvm.py
test_03_ssvm_internals Failure 0.05 test_ssvm.py
test_04_cpvm_internals Failure 0.05 test_ssvm.py
test_05_stop_ssvm Failure 0.05 test_ssvm.py
test_06_stop_cpvm Failure 0.04 test_ssvm.py
test_07_reboot_ssvm Failure 0.05 test_ssvm.py
test_08_reboot_cpvm Failure 0.04 test_ssvm.py
test_09_reboot_ssvm_forced Failure 0.04 test_ssvm.py
test_10_reboot_cpvm_forced Failure 0.04 test_ssvm.py
test_11_destroy_ssvm Failure 0.05 test_ssvm.py
test_12_destroy_cpvm Failure 0.05 test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup Error 0.00 test_storage_policy.py
test_02_create_template_with_checksum_sha1 Error 65.71 test_templates.py
test_03_create_template_with_checksum_sha256 Error 65.76 test_templates.py
test_04_create_template_with_checksum_md5 Error 65.69 test_templates.py
test_05_create_template_with_no_checksum Error 65.71 test_templates.py
ContextSuite context=TestTemplates>:setup Error 7.64 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestLBRuleUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestNatRuleUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestPublicIPUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestSnapshotUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestTemplateUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
ContextSuite context=TestVMDeploymentPlanner>:setup Error 0.00 test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup Error 0.01 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 0.02 test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import Skipped --- test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule Skipped --- test_vm_schedule.py
all_test_vm_snapshot_kvm Skipped --- test_vm_snapshot_kvm.py
all_test_vm_snapshots Skipped --- test_vm_snapshots.py
all_test_vm_strict_host_tags Skipped --- test_vm_strict_host_tags.py
all_test_vnf_templates Skipped --- test_vnf_templates.py
all_test_volumes Skipped --- test_volumes.py
all_test_vpc_ipv6 Skipped --- test_vpc_ipv6.py
all_test_vpc_redundant Skipped --- test_vpc_redundant.py

blueorangutan avatar Sep 05 '24 15:09 blueorangutan

[SF] Trillian test result (tid-11350) Environment: vmware-80u1 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 70447 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9591-t11350-vmware-80u1.zip Smoke tests completed. 132 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_11_test_unmanaged_cluster_lifecycle Error 151.95 test_kubernetes_clusters.py
test_05_list_volumes_isrecursive Failure 0.05 test_list_volumes.py
test_07_list_volumes_listall Failure 0.04 test_list_volumes.py
test_01_deployVMInSharedNetwork Error 201.43 test_network.py
test_02_vpc_privategw_static_routes Error 452.22 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 89.81 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 671.58 test_privategw_acl.py
test_02_restore_vm_with_disk_offering Error 103.70 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 54.23 test_restore_vm.py
test_01_volume_usage Error 93.96 test_usage.py

blueorangutan avatar Sep 05 '24 18:09 blueorangutan