apache
Linstor: Fix migrate primary storage
Description
This PR fixes migrate primary storage for Linstor primary storage. Always use RAW as copy sourceFormat for Linstor devices, as all images are stored as RAW on Linstor, but we have to pretend to use qcow2 to be able to use qcow2 as snapshot format. Also use .getPath() for resource names, as they are altered after a primary storage migration. Fixes: #9176 and #9522
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Linstor Cluster with migrating VM volumes between Linstor and NFS primary storage
How did you try to break this feature and the system with this change?
Migrated from Linstor to NFS and back to NFS, than tried various volume actions like snaphots and revert.
If it helps, I can make the:
- kvm: add more volume info to KVMPhysicalDisk
- linstor: use added KVMPhysicalDisk info for Aux properties
commits into its own PR.
Codecov Report
Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.
Project coverage is 15.08%. Comparing base (
eaab991) to head (ebcf66a). Report is 25 commits behind head on 4.19.
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9528 +/- ##
===========================================
Coverage 15.08% 15.08%
- Complexity 11180 11185 +5
===========================================
Files 5406 5406
Lines 472915 472942 +27
Branches 61731 58606 -3125
===========================================
+ Hits 71326 71350 +24
- Misses 393647 393648 +1
- Partials 7942 7944 +2
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.30% <ø> (ø) |
|
| unittests | 15.80% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10928
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10993
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-11375) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44760 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9528-t11375-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
The code LGTM, but I haven't tested it
Are you alright with merging as is @slavkap ?
