Set CORS headers for both http/https in SSVM apache config

[salfers]

Description

This PR sets the necessary CORS headers on the SSVM independently of protocol.

Fixes: #9366

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI
• [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

How Has This Been Tested?

I have not tested this. If you have any advice how I can properly test changes made to system VMs, please let me know.

[boring-cyborg[bot]]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.54%. Comparing base (afdf4d7) to head (a297c4f).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9389      +/-   ##
============================================
- Coverage     15.54%   15.54%   -0.01%     
  Complexity    11976    11976              
============================================
  Files          5493     5493              
  Lines        481030   481030              
  Branches      60247    60998     +751     
============================================
- Hits          74766    74764       -2     
- Misses       398000   398003       +3     
+ Partials       8264     8263       -1     

Flag	Coverage Δ
uitests	4.16% <ø> (ø)
unittests	16.31% <ø> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[salfers]

I just noticed that removing useHttpsToUpload entirely could affect other code. I got rid of that now.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10635

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11071) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 50927 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9389-t11071-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	406.05	test_vm_life_cycle.py

[salfers]

@DaanHoogland any news?

[DaanHoogland]

@DaanHoogland any news?

needs another review and some 3rd person testing, @salfers .

[DaanHoogland]

@weizhouapache , can you have a look at this?

[weizhouapache]

@DaanHoogland the author @salfers mentioned I have not tested this., are we going to merge it ?

[DaanHoogland]

@DaanHoogland the author @salfers mentioned I have not tested this., are we going to merge it ?

not like that of course (duh?)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15393

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14621)

[blueorangutan]

[SF] Trillian test result (tid-14624) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55708 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9389-t14624-kvm-ol8.zip Smoke tests completed. 149 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File