cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

UI: Remove the delete action item for cks nodes

Open kiranchavala opened this issue 1 year ago • 2 comments

ISSUE TYPE

Improvement issue

COMPONENT NAME

Component: UI

CLOUDSTACK VERSION

Cloudstack version 4.19.0

SUMMARY

Remove the delete action item for kubernetes nodes inside a cks cluster

Steps to reproduce the issue

  1. Create cks cluster and navigate inside the cks cluster

Remove the delete action item

Currently, we are throwing a exception whenever a user tries to delete the kubernetes node based on this

https://github.com/apache/cloudstack/pull/9057

In my opinion its better not to show the delete icon , when the operation is expected to fail,

End user should be only allowed to delete the cks cluster from the UI

Expected behaviour

Remove the delete action item for the cks nodes

kiranchavala avatar Jun 24 '24 10:06 kiranchavala

@kiranchavala I believe the PR #9057 prevents deletion of the CKS nodes using the destroyVirtualMachine API from the instances tab. These delete icons basically translate to scaleKubernetesCluster which effectively scales down a specific node in the CKS cluster

Pearl1594 avatar Jun 27 '24 13:06 Pearl1594

@Pearl1594 , you are saying it is solved in #9057 ?

DaanHoogland avatar Jul 01 '24 08:07 DaanHoogland

Fixed by https://github.com/apache/cloudstack/pull/9434

rohityadavcloud avatar Jul 29 '24 05:07 rohityadavcloud