cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

engine-storage: Set SecretConsumerDetail for VM live migration with storage on shared NFS

Open abh1sar opened this issue 8 months ago • 34 comments

Description

Fixes https://github.com/apache/cloudstack/issues/8255

This PR Fixes the issue where live migration of a VM with encrypted volume on shared NFS due to wrongly setup secret key on the destination. Before fix uuid of the secret key was corresponding to the source volume, while actually it should be of the destination volume.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [x] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Reproduced the original issue by

  1. Create a VM with encrypted data volume
  2. Open the Live VM migrate UI wizard
  3. Select Migrate with Storage option and made sure that the data volume is moved to a different pool.
  4. Start live migrate.

How did you try to break this feature and the system with this change?

abh1sar avatar Jun 11 '24 14:06 abh1sar