refactor: cloud-sysvmadm script

[shwstppr]

Description

Fixes: #9000

• Fixes script, mainly the queryAsyncJobResult response parsing
• Indentations
• Use uuid instead of database id

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [x] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

root@pr8601-t6928-kvm-ubuntu22-mgmt1:~# /usr/bin/cloudstack-sysvmadm -p pssword -s
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.

Stopping and starting 1 secondary storage vm(s)...
Done stopping and starting secondary storage vm(s)

Stopping and starting 1 console proxy vm(s)...
Done stopping and starting console proxy vm(s) .

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.07%. Comparing base (54c8b71) to head (96e7c36). Report is 51 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9200    +/-   ##
==========================================
  Coverage     15.07%   15.07%            
- Complexity    11169    11171     +2     
==========================================
  Files          5405     5405            
  Lines        472677   472677            
  Branches      60049    59608   -441     
==========================================
+ Hits          71269    71272     +3     
+ Misses       393479   393477     -2     
+ Partials       7929     7928     -1     

Flag	Coverage Δ
uitests	4.27% <ø> (ø)
unittests	15.79% <ø> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9892

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10486) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52697 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9200-t10486-kvm-centos7.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	246.88	test_kubernetes_clusters.py
test_02_trigger_shutdown	Failure	341.64	test_safe_shutdown.py
test_05_vmschedule_test_e2e	Failure	361.84	test_vm_schedule.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10326

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[shwstppr]

I don't see this script being called in the code anywhere so not sure if smoke tests would find anything

[DaanHoogland]

I don't see this script being called in the code anywhere so not sure if smoke tests would find anything

sorry, blind execution

[blueorangutan]

[SF] Trillian test result (tid-10810) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47918 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9200-t10810-kvm-centos7.zip Smoke tests completed. 131 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	Error	3966.88	test_vm_life_cycle.py
test_09_expunge_vm	Failure	427.61	test_vm_life_cycle.py

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10944

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10961