apache
pre-commit: add hook `check-yaml`
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml
Description
This PR adds another check or test to our pre-commit framework.
From the official pre-commit organization.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [X] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Ran locally:
pre-commit run --all-files
How did you try to break this feature and the system with this change?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 16.06%. Comparing base (
b48de4e) to head (58dfd88). Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9133 +/- ##
=========================================
Coverage 16.06% 16.06%
- Complexity 12871 12872 +1
=========================================
Files 5642 5642
Lines 493973 493973
Branches 59895 59895
=========================================
+ Hits 79348 79351 +3
+ Misses 405839 405837 -2
+ Partials 8786 8785 -1
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.01% <ø> (ø) |
|
| unittests | 16.90% <ø> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10279
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11334
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11460
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11466
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11870
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11928
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-12001) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 109701 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9133-t12001-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_invalid_upgrade_kubernetes_cluster | Failure |
3643.80 | test_kubernetes_clusters.py |
| test_02_upgrade_kubernetes_cluster | Failure |
3647.44 | test_kubernetes_clusters.py |
| test_03_deploy_and_scale_kubernetes_cluster | Failure |
3651.16 | test_kubernetes_clusters.py |
| test_04_autoscale_kubernetes_cluster | Failure |
3639.69 | test_kubernetes_clusters.py |
| test_05_basic_lifecycle_kubernetes_cluster | Failure |
3638.84 | test_kubernetes_clusters.py |
| test_06_delete_kubernetes_cluster | Failure |
3645.39 | test_kubernetes_clusters.py |
| test_08_upgrade_kubernetes_ha_cluster | Failure |
3669.90 | test_kubernetes_clusters.py |
| test_10_vpc_tier_kubernetes_cluster | Failure |
3702.86 | test_kubernetes_clusters.py |
| test_01_redundant_vpc_site2site_vpn | Failure |
457.66 | test_vpc_vpn.py |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-12003) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 111134 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9133-t12003-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_invalid_upgrade_kubernetes_cluster | Failure |
3648.09 | test_kubernetes_clusters.py |
| test_02_upgrade_kubernetes_cluster | Failure |
3650.24 | test_kubernetes_clusters.py |
| test_03_deploy_and_scale_kubernetes_cluster | Failure |
3653.89 | test_kubernetes_clusters.py |
| test_04_autoscale_kubernetes_cluster | Failure |
3649.40 | test_kubernetes_clusters.py |
| test_05_basic_lifecycle_kubernetes_cluster | Failure |
3653.54 | test_kubernetes_clusters.py |
| test_06_delete_kubernetes_cluster | Failure |
3638.83 | test_kubernetes_clusters.py |
| test_08_upgrade_kubernetes_ha_cluster | Failure |
3675.58 | test_kubernetes_clusters.py |
| test_10_vpc_tier_kubernetes_cluster | Failure |
3708.02 | test_kubernetes_clusters.py |
Hi guys @jbampton @DaanHoogland @vishesh92 I'm not able to get CKS clusters into Running state after these changes (at least after merging main branch on my PR #9102):
Accessing one of the CKS nodes I could check there were syntax errors which I could work around by reverting this PR changes. I haven't tried on the current main branch yet but I suspect the same issue could be present there
Sorry @nvazquez , I was a bit eager on this one, let's revert. cc @vishesh92 @jbampton @nvazquez , do you see a possibility to make this check work (by options on the check or a syntax change in the yamls)?