apache
cks: fix events
Description
Fixes #8043
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 9.75610% with 185 lines in your changes missing coverage. Please review.
Project coverage is 14.95%. Comparing base (
c779b1c) to head (1ffae17). Report is 22 commits behind head on 4.19.
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9070 +/- ##
============================================
- Coverage 14.96% 14.95% -0.01%
- Complexity 10994 11005 +11
============================================
Files 5373 5377 +4
Lines 469248 469628 +380
Branches 58967 59124 +157
============================================
+ Hits 70220 70255 +35
- Misses 391253 391594 +341
- Partials 7775 7779 +4
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.29% <ø> (-0.01%) |
:arrow_down: |
| unittests | 15.67% <9.75%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9611
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9621
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9636
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
@DaanHoogland this PR just fixes events for different CKS actions for both k8s cluster and k8s supported versions. Mainly the resources linked to the events. I'm not sure what can be added in a doc PR. Do you have any suggestions?
@DaanHoogland this PR just fixes events for different CKS actions for both k8s cluster and k8s supported versions. Mainly the resources linked to the events. I'm not sure what can be added in a doc PR. Do you have any suggestions?
It is not specific to this PR, but I think we can look at more specific event documentation. I had a quick search of the docs and do not see any event documentation for other resources either. Just a thought. Forget it for now.
[SF] Trillian test result (tid-10234) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43609 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9070-t10234-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
418.55 | test_events_resource.py |
| test_02_trigger_shutdown | Failure |
341.77 | test_safe_shutdown.py |
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9747
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10339) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46542 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9070-t10339-kvm-centos7.zip Smoke tests completed. 131 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9884
@shwstppr LGTM but pl check if the package-lock.json needs to be removed and re-added in format/version 1, if only required:
npm i --lockfile-version 1
This is because, changing the lock file version may not work with older/other npm versions or cause unknown consequences due to change in direct/indirect dependencies; full UI QA may be necessary when/if this happens.
Thanks @rohityadavcloud. Reverted package-lock.json. I must've added it by mistake