server: honor listall param for listiso api

[shwstppr]

Description

Fixes #8315

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (87e7c57) to head (4229c49). Report is 3 commits behind head on 4.19.

Files	Patch %	Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9064      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10990       -5     
============================================
  Files          5373     5373              
  Lines        469005   469024      +19     
  Branches      58953    59317     +364     
============================================
- Hits          70198    70193       -5     
- Misses       391036   391060      +24     
  Partials       7771     7771              

Flag	Coverage Δ
uitests	4.31% <ø> (ø)
unittests	15.67% <0.00%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9585

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-10212)

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9657

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10250) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52554 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10250-kvm-centos7.zip Smoke tests completed. 127 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	405.91	test_events_resource.py
test_08_arping_in_ssvm	Failure	5.22	test_diagnostics.py
test_09_arping_in_cpvm	Failure	5.27	test_diagnostics.py
test_02_trigger_shutdown	Failure	346.84	test_safe_shutdown.py
test_01_redundant_vpc_site2site_vpn	Failure	410.44	test_vpc_vpn.py

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9710

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10284) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47567 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9064-t10284-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	Failure	341.65	test_safe_shutdown.py

[shwstppr]

listIsos now return all ISOs when listall is passed,

(local) 🐱 > list isos filter=id,name,ispublic,domainid
{
  "count": 3,
  "iso": [
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
      "ispublic": false,
      "name": "test1"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
      "ispublic": false,
      "name": "test1-dd"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
      "ispublic": false,
      "name": "ds"
    }
  ]
}
(local) 🐱 > list isos filter=id,name,ispublic,domainid listall=true
{
  "count": 9,
  "iso": [
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "6c519636-3b2f-419c-b5bb-baac2c42ee5d",
      "ispublic": true,
      "name": "vmware-tools.iso"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "afa5ca21-6bd1-4682-88bc-c0956606250e",
      "ispublic": true,
      "name": "xs-tools.iso"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "aa621e5c-0689-412f-8b43-5976acdb404e",
      "ispublic": true,
      "name": "v1.26.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "79681074-a7bd-4434-befd-e7c5ad728ee7",
      "ispublic": false,
      "name": "test1"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "fdeb66bc-57ac-491d-b4d8-c6a2545e064c",
      "ispublic": false,
      "name": "test1-dd"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "77c5f629-4e8c-4b04-8fa2-5b08e4a4d8d7",
      "ispublic": false,
      "name": "ds"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "0bb30117-d53a-45e8-b2f5-65c17e635ff1",
      "ispublic": true,
      "name": "v1.24.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "8da34656-08a3-11ef-9779-1e00a7000c5f",
      "id": "969111e5-c6f9-4d46-822f-31c7700ff4d3",
      "ispublic": true,
      "name": "v1.24.0-Kubernetes-Binaries-ISO"
    },
    {
      "domainid": "db8c37e6-1e90-409b-addb-f1d8a9f77ce2",
      "id": "ff67dfbe-1b2b-4dd2-9c7a-309d14a5fc37",
      "ispublic": true,
      "name": "test-domain-iso"
    }
  ]
}