ui: fix dashboard limit format

[shwstppr]

Description

An undefined variable item was used.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [x] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

Before:

After:

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 14.96%. Comparing base (87e7c57) to head (478d495). Report is 3 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9060      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10990       -5     
============================================
  Files          5373     5373              
  Lines        469005   469024      +19     
  Branches      58953    58330     -623     
============================================
- Hits          70198    70183      -15     
- Misses       391036   391071      +35     
+ Partials       7771     7770       -1     

Flag	Coverage Δ
uitests	4.31% <ø> (ø)
unittests	15.66% <ø> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9060 (QA-JID-337)

[DaanHoogland]

@shwstppr , I see no difference between your before and after pictures. Can you highlight what has changed, please?

[shwstppr]

@DaanHoogland there is a difference in before and after screens. There is no percentage label for unlimited resource types (check Instances label)

More importantly in certain scenarios, the code itself is incorrect using the wrong variables. It may log an error similar to that reported in #9045 in certain cases while trying to find undefinedlimit property https://private-user-images.githubusercontent.com/110984295/328852853-5ca04e09-eaa8-4466-bc2d-5df59fad1973.png