cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

vpc,event: fix events for createVpc

Open shwstppr opened this issue 9 months ago • 7 comments

Description

Fixes #8496

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr avatar May 08 '24 07:05 shwstppr

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 14.96%. Comparing base (87e7c57) to head (985b5f4). Report is 3 commits behind head on 4.19.

Files Patch % Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java 0.00% 6 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9055      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10992       -3     
============================================
  Files          5373     5373              
  Lines        469005   469028      +23     
  Branches      58953    59846     +893     
============================================
- Hits          70198    70187      -11     
- Misses       391036   391072      +36     
+ Partials       7771     7769       -2     
Flag Coverage Δ
uitests 4.31% <ø> (ø)
unittests 15.67% <14.28%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 08 '24 08:05 codecov-commenter

@blueorangutan package

shwstppr avatar May 09 '24 06:05 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 09 '24 06:05 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9583

blueorangutan avatar May 09 '24 07:05 blueorangutan

@blueorangutan test

sureshanaparti avatar May 09 '24 09:05 sureshanaparti

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar May 09 '24 09:05 blueorangutan

[SF] Trillian test result (tid-10197) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56113 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9055-t10197-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 418.91 test_events_resource.py
test_04_extract_Iso Failure 16.14 test_iso.py

blueorangutan avatar May 10 '24 01:05 blueorangutan

@blueorangutan package

shwstppr avatar May 24 '24 11:05 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 24 '24 11:05 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9696

blueorangutan avatar May 24 '24 13:05 blueorangutan