cloudstack
cloudstack copied to clipboard
apache
Fixup e2e test_restore_vm
Description
This PR fixes e2e test for restore_vm
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 14.96%. Comparing base (
b91c387) to head (d063987). Report is 3 commits behind head on 4.19.
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #9025 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
+ Complexity 10996 10990 -6
============================================
Files 5373 5373
Lines 468973 468973
Branches 60294 59933 -361
============================================
- Hits 70205 70184 -21
- Misses 390995 391019 +24
+ Partials 7773 7770 -3
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.31% <ø> (ø) |
|
| unittests | 15.67% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9512
@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10136) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44500 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9025-t10136-kvm-centos7.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
407.33 | test_events_resource.py |
| test_create_pvlan_network | Error |
0.08 | test_pvlan.py |
| test_01_restore_vm | Error |
73.49 | test_restore_vm.py |
| test_02_restore_vm_allocated_root | Error |
1.26 | test_restore_vm.py |
[SF] Trillian test result (tid-10127) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 53034 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9025-t10127-vmware-67u3.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
325.09 | test_events_resource.py |
| test_02_balanced_drs_algorithm | Failure |
139.47 | test_cluster_drs.py |
| test_01_restore_vm | Error |
44.95 | test_restore_vm.py |
| test_02_restore_vm_allocated_root | Error |
1.53 | test_restore_vm.py |
======================================================================
ERROR: Test restore virtual machine
----------------------------------------------------------------------
Traceback (most recent call last):
File "/marvin/tests/smoke/test_restore_vm.py", line 75, in test_01_restore_vm
self.assertEqual(root_vol.size, self.template_t1.size, "Size of volume and template should match")
AttributeError: 'Template' object has no attribute 'size'
and
======================================================================
ERROR: Test restore virtual machine with root disk in allocated state
----------------------------------------------------------------------
Traceback (most recent call last):
File "/marvin/tests/smoke/test_restore_vm.py", line 97, in test_02_restore_vm_allocated_root
self.assertEqual(root_vol.size, self.template_t1.size, "Size of volume and template should match")
AttributeError: 'Template' object has no attribute 'size'
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9533
@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10160) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43438 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9025-t10160-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
406.21 | test_events_resource.py |
| test_02_trigger_shutdown | Failure |
341.75 | test_safe_shutdown.py |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9542
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9544
@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10168) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44205 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9025-t10168-kvm-centos7.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
418.88 | test_events_resource.py |