cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

VNF: add API listVnfAppliances

Open weizhouapache opened this issue 1 year ago • 20 comments

Description

This PR fixes #8979

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache avatar Apr 26 '24 14:04 weizhouapache

@blueorangutan package

weizhouapache avatar Apr 26 '24 14:04 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 26 '24 14:04 blueorangutan

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.95%. Comparing base (e409c6d) to head (8da6669). Report is 15 commits behind head on 4.19.

Files Patch % Lines
...tack/api/command/user/vm/ListVnfAppliancesCmd.java 0.00% 4 Missing :warning:
...stack/storage/template/VnfTemplateManagerImpl.java 0.00% 2 Missing :warning:
.../command/admin/vm/ListVnfAppliancesCmdByAdmin.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8994      +/-   ##
============================================
- Coverage     14.96%   14.95%   -0.01%     
+ Complexity    10995    10983      -12     
============================================
  Files          5373     5375       +2     
  Lines        468989   468910      -79     
  Branches      61009    60158     -851     
============================================
- Hits          70191    70146      -45     
+ Misses       391019   390995      -24     
+ Partials       7779     7769      -10     
Flag Coverage Δ
uitests 4.31% <ø> (-0.01%) :arrow_down:
unittests 15.66% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 26 '24 14:04 codecov-commenter

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9447

blueorangutan avatar Apr 26 '24 15:04 blueorangutan

@blueorangutan package

weizhouapache avatar Apr 29 '24 08:04 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 29 '24 08:04 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9462

blueorangutan avatar Apr 29 '24 09:04 blueorangutan

@blueorangutan test

weizhouapache avatar Apr 29 '24 09:04 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Apr 29 '24 09:04 blueorangutan

[SF] Trillian test result (tid-10079) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43610 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8994-t10079-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 410.24 test_events_resource.py
test_01_restore_vm Error 0.26 test_restore_vm.py
test_02_restore_vm_allocated_root Error 0.20 test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown Error 1.30 test_restore_vm.py

blueorangutan avatar Apr 29 '24 22:04 blueorangutan

@blueorangutan package

weizhouapache avatar Apr 30 '24 06:04 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 30 '24 06:04 blueorangutan

Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9475

blueorangutan avatar Apr 30 '24 07:04 blueorangutan

@blueorangutan package

weizhouapache avatar Apr 30 '24 08:04 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 30 '24 08:04 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9479

blueorangutan avatar Apr 30 '24 09:04 blueorangutan

@blueorangutan test rocky8 kvm-rocky8

weizhouapache avatar Apr 30 '24 09:04 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan avatar Apr 30 '24 09:04 blueorangutan

[SF] Trillian test result (tid-10087) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 50813 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8994-t10087-kvm-rocky8.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 420.49 test_events_resource.py
test_01_restore_vm Error 0.34 test_restore_vm.py
test_02_restore_vm_allocated_root Error 0.23 test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown Error 1.35 test_restore_vm.py

blueorangutan avatar May 01 '24 00:05 blueorangutan

@vladimirpetrov can you verify when possible ? thanks

weizhouapache avatar May 01 '24 08:05 weizhouapache