cloudstack
cloudstack copied to clipboard
apache
Fix message publish in transaction
Description
This PR fixes the below error log on deleting a shared network.
2024-04-24 18:24:33,831 ERROR [o.a.c.f.m.MessageBusBase] (API-Job-Executor-14:ctx-63de092f job-2044 ctx-d00db98a) (logid:107d5ed5) NO EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSAC
TION!
com.cloud.utils.exception.CloudRuntimeException: NO EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSACTION!
at org.apache.cloudstack.framework.messagebus.MessageBusBase.publish(MessageBusBase.java:167)
at com.cloud.configuration.ConfigurationManagerImpl.deleteVlanAndPublicIpRange(ConfigurationManagerImpl.java:5345)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy156.deleteVlanAndPublicIpRange(Unknown Source)
at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.deleteVlansInNetwork(NetworkOrchestrator.java:3368)
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Codecov Report
Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.
Project coverage is 14.96%. Comparing base (
e409c6d) to head (d4388cb). Report is 15 commits behind head on 4.19.
| Files | Patch % | Lines |
|---|---|---|
| ...tack/engine/orchestration/NetworkOrchestrator.java | 0.00% | 19 Missing :warning: |
| .../cloud/configuration/ConfigurationManagerImpl.java | 0.00% | 10 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #8980 +/- ##
===========================================
Coverage 14.96% 14.96%
- Complexity 10995 10996 +1
===========================================
Files 5373 5373
Lines 468989 468992 +3
Branches 61009 58066 -2943
===========================================
+ Hits 70191 70205 +14
+ Misses 391019 391014 -5
+ Partials 7779 7773 -6
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.31% <ø> (-0.01%) |
:arrow_down: |
| unittests | 15.67% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9430
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10041) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47282 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10041-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
420.84 | test_events_resource.py |
@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10077) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47378 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10077-kvm-centos7.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
418.26 | test_events_resource.py |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9502
@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-10121) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42597 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8980-t10121-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_events_resource | Error |
416.50 | test_events_resource.py |
| test_01_restore_vm | Error |
0.23 | test_restore_vm.py |
| test_02_restore_vm_allocated_root | Error |
0.17 | test_restore_vm.py |
| ContextSuite context=TestRestoreVM>:teardown | Error |
1.27 | test_restore_vm.py |