cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

pom.xml: Upgrade gson version to 2.10.1

Open weizhouapache opened this issue 11 months ago • 42 comments

Description

This PR upgrades gson from 1.7.2 to 2.10.1

gson versions are listed at https://mvnrepository.com/artifact/com.google.code.gson/gson

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache avatar Mar 07 '24 10:03 weizhouapache

@blueorangutan package

weizhouapache avatar Mar 07 '24 10:03 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Mar 07 '24 10:03 blueorangutan

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (20901c7) to head (3bcbb04).

Files with missing lines Patch % Lines
.../api/response/ClusterDrsPlanMigrationResponse.java 0.00% 2 Missing :warning:
...va/com/cloud/agent/transport/ArrayTypeAdaptor.java 71.42% 2 Missing :warning:
.../apache/cloudstack/metrics/MetricsServiceImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #8756    +/-   ##
==========================================
  Coverage     15.78%   15.78%            
- Complexity    12564    12565     +1     
==========================================
  Files          5627     5627            
  Lines        492266   492256    -10     
  Branches      63860    62898   -962     
==========================================
+ Hits          77707    77714     +7     
+ Misses       406084   406065    -19     
- Partials       8475     8477     +2     
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 16.60% <61.53%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 10:03 codecov[bot]

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8875

blueorangutan avatar Mar 07 '24 11:03 blueorangutan

RequestTest & LogUtilsTest are failing. (Other tests might be failing as well. haven't checked). We will need to go through the release notes and ensure that we don't break anything. https://github.com/google/gson/blob/main/CHANGELOG.md

vishesh92 avatar Mar 07 '24 12:03 vishesh92

RequestTest & LogUtilsTest are failing. (Other tests might be failing as well. haven't checked). We will need to go through the release notes and ensure that we don't break anything. https://github.com/google/gson/blob/main/CHANGELOG.md

yes @vishesh92 I marked it as draft . I will revisit it later.

weizhouapache avatar Mar 07 '24 13:03 weizhouapache

@blueorangutan package

weizhouapache avatar Mar 13 '24 16:03 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Mar 13 '24 16:03 blueorangutan

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8925

blueorangutan avatar Mar 13 '24 17:03 blueorangutan

now the only issue with simulator CI is caused by Execute cmd: generateclusterdrsplan failed, due to: errorCode: 431, errorText:Class org.apache.cloudstack.api.response.ClusterDrsPlanMigrationResponse declares multiple JSON fields named 'jobid'; conflict is caused by fields org.apache.cloudstack.api.response.ClusterDrsPlanMigrationResponse#jobId and org.apache.cloudstack.api.BaseResponse#jobId"

https://github.com/apache/cloudstack/blob/bb244842fa14006cddd013401d2e87f758535cc0/api/src/main/java/org/apache/cloudstack/api/BaseResponse.java#L27-L33

https://github.com/apache/cloudstack/blob/bb244842fa14006cddd013401d2e87f758535cc0/api/src/main/java/org/apache/cloudstack/api/response/ClusterDrsPlanMigrationResponse.java#L53-L59

the two files have same name jobId and jobStatus but different type.

@vishesh92

weizhouapache avatar Mar 15 '24 10:03 weizhouapache

@blueorangutan package

weizhouapache avatar Mar 22 '24 08:03 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Mar 22 '24 08:03 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9004

blueorangutan avatar Mar 22 '24 09:03 blueorangutan

@blueorangutan test rocky8 kvm-rocky8

weizhouapache avatar Mar 22 '24 10:03 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan avatar Mar 22 '24 10:03 blueorangutan

[SF] Trillian test result (tid-9557) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 56215 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t9557-kvm-rocky8.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Error 124.67 test_cluster_drs.py
test_02_balanced_drs_algorithm Error 122.03 test_cluster_drs.py
test_01_redundant_vpc_site2site_vpn Failure 706.42 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 585.03 test_vpc_vpn.py

blueorangutan avatar Mar 23 '24 02:03 blueorangutan

@blueorangutan package

weizhouapache avatar Mar 23 '24 09:03 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Mar 23 '24 09:03 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9016

blueorangutan avatar Mar 23 '24 10:03 blueorangutan

@blueorangutan test rocky8 kvm-rocky8

weizhouapache avatar Mar 23 '24 12:03 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

blueorangutan avatar Mar 23 '24 12:03 blueorangutan

[SF] Trillian test result (tid-9563) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 58266 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t9563-kvm-rocky8.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 100.33 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 55.93 test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn Failure 680.88 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 354.70 test_vpc_vpn.py

blueorangutan avatar Mar 24 '24 05:03 blueorangutan

@blueorangutan package

weizhouapache avatar May 07 '24 08:05 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 07 '24 08:05 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9561

blueorangutan avatar May 07 '24 09:05 blueorangutan

@blueorangutan test matrix

DaanHoogland avatar May 07 '24 09:05 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar May 07 '24 09:05 blueorangutan

[SF] Trillian test result (tid-10175) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48932 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t10175-xenserver-71.zip Smoke tests completed. 130 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 348.55 test_events_resource.py

blueorangutan avatar May 07 '24 23:05 blueorangutan

[SF] Trillian test result (tid-10176) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 53593 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t10176-vmware-67u3.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 348.61 test_events_resource.py
test_02_balanced_drs_algorithm Error 428.94 test_cluster_drs.py

blueorangutan avatar May 08 '24 00:05 blueorangutan

[SF] Trillian test result (tid-10177) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 56411 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t10177-kvm-centos7.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 434.66 test_events_resource.py
test_02_trigger_shutdown Failure 351.85 test_safe_shutdown.py
test_01_redundant_vpc_site2site_vpn Failure 603.71 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 510.87 test_vpc_vpn.py

blueorangutan avatar May 08 '24 01:05 blueorangutan