Limit infrastructure details revealed to the end user after a failed migration on KVM

[GaOrtiga]

Description

When a migration error occurs on KVM, the message Migration was refused connection to destination: <destination Uri>. Please check libvirt configuration compatibility and firewall rules on the source and destination hosts. is presented to the user. This discloses infrastructure information which should not be available to the end user.

This message was substituted by a generic message, to avoid exposing infrastructure information. A new log was also added, containing the previous content of the message, in order to enable debugging.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [X] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [X] Minor

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 23.19%. Comparing base (592038a) to head (62560bf). Report is 36 commits behind head on main.

Files	Patch %	Lines
...resource/wrapper/LibvirtMigrateCommandWrapper.java	0.00%	2 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8680      +/-   ##
============================================
+ Coverage     23.14%   23.19%   +0.04%     
- Complexity    23348    23406      +58     
============================================
  Files          5219     5219              
  Lines        353412   353413       +1     
  Branches      50883    50883              
============================================
+ Hits          81805    81957     +152     
+ Misses       259762   259593     -169     
- Partials      11845    11863      +18     

Flag	Coverage Δ
simulator-marvin-tests	24.86% <0.00%> (+0.04%)	:arrow_up:
uitests	4.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8952

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8993

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9569) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51351 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8680-t9569-kvm-alma9.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_list_storage_pools_keyword_filter	Error	0.02	test_list_storage_pools.py

[JoaoJandre]

Merging based on approvals and tests. The only test failure is not related in this PR (was fixed in https://github.com/apache/cloudstack/pull/8814)