cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Show network metrics for System VMs

Open GaOrtiga opened this issue 1 year ago • 3 comments

Description

The Network metrics segment of the UI displays the amount of data downloaded/uploaded by a specific instance. However, when the instance is a system VM (VR, CPVM or SSVM), this segment is not shown.

This behaviour has been fixed, allowing network metrics for System VMs to be viewed via UI.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [X] Minor
  • [ ] Trivial

Screenshots (if appropriate):

Before

Console Proxy: consoleProxyBefore

Secondary Storage: SecondaryStorageBefore

Virtual Router: routerBefore

After

Console Proxy: consoleProxyAfter

Secondary Storage: secondaryStorageAfter

Virtual Router: routerAfter

How Has This Been Tested?

How did you try to break this feature and the system with this change?

GaOrtiga avatar Feb 19 '24 17:02 GaOrtiga

@blueorangutan ui

DaanHoogland avatar Feb 20 '24 10:02 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Feb 20 '24 10:02 blueorangutan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (592038a) 23.14% compared to head (aa6aa5b) 30.92%. Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8679      +/-   ##
============================================
+ Coverage     23.14%   30.92%   +7.78%     
- Complexity    23348    33428   +10080     
============================================
  Files          5219     5355     +136     
  Lines        353412   375727   +22315     
  Branches      50883    54915    +4032     
============================================
+ Hits          81805   116207   +34402     
+ Misses       259762   244111   -15651     
- Partials      11845    15409    +3564     
Flag Coverage Δ
simulator-marvin-tests 24.77% <ø> (-0.05%) :arrow_down:
uitests 4.36% <ø> (ø)
unit-tests 16.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 10:02 codecov[bot]

@DaanHoogland @rohityadavcloud @GutoVeronezi @weizhouapache @sureshanaparti

Could someone review this?

GaOrtiga avatar Mar 19 '24 10:03 GaOrtiga

@blueorangutan ui

DaanHoogland avatar Mar 25 '24 09:03 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Mar 25 '24 09:03 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8679 (QA-JID-304)

blueorangutan avatar Mar 25 '24 09:03 blueorangutan