cloudstack
cloudstack copied to clipboard
apache
feature: webhooks
Description
Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Webhooks
Webhooks allow external services to be notified when certain events happen.
To implement and make Webhook work as an event bus, changes have been made to publish messages on multiple active message buses. Fixes #6778
Documentation PR: https://github.com/apache/cloudstack-documentation/pull/385
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 58.53324% with 605 lines in your changes are missing coverage. Please review.
Project coverage is 31.34%. Comparing base (
a0b642c) to head (b054e0c). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #8674 +/- ##
============================================
+ Coverage 30.91% 31.34% +0.43%
- Complexity 33734 34355 +621
============================================
Files 5404 5432 +28
Lines 380289 381645 +1356
Branches 55489 55655 +166
============================================
+ Hits 117550 119634 +2084
+ Misses 247104 246194 -910
- Partials 15635 15817 +182
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 25.20% <68.63%> (+0.66%) |
:arrow_up: |
| uitests | 4.31% <1.38%> (-0.03%) |
:arrow_down: |
| unit-tests | 16.89% <18.97%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8718
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8720
[SF] Trillian test result (tid-9301) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46591 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8674-t9301-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@shwstppr do you have any description of the feature?
@GutoVeronezi yes, I've added a feature spec at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Webhooks This is still in WIP so some specific details around namings may change over time.
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8737
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8752
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8793
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8799
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8809
@DaanHoogland thanks. Will address logging changes together with any remaining review comments
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.