cloudstack
cloudstack copied to clipboard
Github Action: Add action to auto close issues/PRs after a certain time
Description
This PR adds a github action to close stale issues and PRs after a certain time.
This action will mark the issue/PR as stale after 90 days. It will add a label and comment marking it as stale. If there is no activity on an issue/PR after it has been marked stale, it will get closed after 30 days.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [x] build/CI
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a31449b) 30.76% compared to head (8222c94) 30.80%.
Additional details and impacted files
@@ Coverage Diff @@
## main #8667 +/- ##
============================================
+ Coverage 30.76% 30.80% +0.03%
- Complexity 33076 33128 +52
============================================
Files 5353 5353
Lines 374607 374607
Branches 54635 54635
============================================
+ Hits 115238 115383 +145
+ Misses 244099 243924 -175
- Partials 15270 15300 +30
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 24.68% <ø> (+0.05%) |
:arrow_up: |
| uitests | 4.38% <ø> (ø) |
|
| unit-tests | 16.43% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
agree with Daan
we need to consider the labels. also the current days (90/30) is too agressive I think.
looks good but, ... (not saying "no"!) can we use some of these: exempt-issue-labels Labels on issues exempted from stale exempt-pr-labels Labels on PRs exempted from stale only-labels Only issues/PRs with ALL these labels are checked only-issue-labels Override only-labels for issues only only-pr-labels Override only-labels for PRs only any-of-labels Only issues/PRs with ANY of these labels are checked any-of-issue-labels Override any-of-labels for issues only any-of-pr-labels Override any-of-labels for PRs only
for instance with the unplanned milestone we might want to keep things around longer. or ready-for-merge we might want to exempt (during freeze)
that said lgtm
@DaanHoogland @weizhouapache Let me update the PR.
@weizhouapache After how many days should we mark stale or close the PRs?
@DaanHoogland @weizhouapache Let me update the PR.
@weizhouapache After how many days should we mark stale or close the PRs?
I just went through the issues, actually most of the issues were created in 2023 , few of them in 2022. I am not sure how many days we should set. maybe 1 year ?
@vishesh92 is this being discussed on the dev@ ML ? Perhaps nudge the community (again)?
@vishesh92 I like the general idea of it, some questions; how does it consider an issue or PR to be stale (is it by last activity such as commits or comments, or by date of when the issue/PR was opened)? Could we do something like anything opened beyond 2yr+ is closed, as it's not fixed/resolved to the effect in the last 2yr+?
Otherwise LGTM on the general idea, the specific duration may need tweaking.