cloudstack
cloudstack copied to clipboard
api,server,ui: add project ID and name to UserDataResponse
Description
This PR fixes #8363
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.
Comparison is base (
bda49ab) 30.90% compared to head (fb54df0) 30.90%. Report is 2 commits behind head on 4.19.
| Files | Patch % | Lines |
|---|---|---|
| ...ache/cloudstack/api/response/UserDataResponse.java | 0.00% | 4 Missing :warning: |
| ui/src/config/section/compute.js | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #8656 +/- ##
============================================
- Coverage 30.90% 30.90% -0.01%
+ Complexity 34189 34187 -2
============================================
Files 5347 5347
Lines 375566 375570 +4
Branches 54625 54626 +1
============================================
- Hits 116068 116056 -12
- Misses 244236 244250 +14
- Partials 15262 15264 +2
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 24.75% <20.00%> (-0.01%) |
:arrow_down: |
| uitests | 4.39% <20.00%> (-0.01%) |
:arrow_down: |
| unit-tests | 16.55% <0.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8664
@weizhouapache , given the name of your branch is this for 4.19?
@weizhouapache , given the name of your branch is this for 4.19?
@DaanHoogland the branch is based on 4.19. However, I added to 4.20.0.0 milestone as I am not sure if it is a bug fix. If it is, we can change the target branch to 4.19
I think a backwards compatible enhancement like this can go into a minor release.
I think a backwards compatible enhancement like this can go into a minor release.
OK @DaanHoogland
changed the target branch to 4.19
I will add since in response.
@blueorangutan package
@blueorangutan package
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8678
@blueorangutan test
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
@blueorangutan test
@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-9430) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46848 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8656-t9430-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_07_arping_in_vr | Failure |
5.18 | test_diagnostics.py |
@sureshanaparti , I think we can merge at your will.