cloudstack UI Fixes: allow filtering on alertype in UI & add events tab

Description

This PR fixes https://github.com/apache/cloudstack/issues/8063 Fixes https://github.com/apache/cloudstack/issues/7251 Fixes https://github.com/apache/cloudstack/issues/8522 Fixes https://github.com/apache/cloudstack/issues/7193 This also adds a new command listAlertTypes to list all alert types to be used in filtering for listing alerts in UI.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Feb 08 '24 17:02 vishesh92

Codecov Report

Attention: Patch coverage is 20.00000% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 30.90%. Comparing base (a924a11) to head (9967e27). Report is 41 commits behind head on 4.19.

Files	Patch %	Lines
ui/src/components/view/SearchView.vue	0.00%	21 Missing :warning:
ui/src/config/section/offering.js	0.00%	17 Missing :warning:
.../api/command/admin/resource/ListAlertTypesCmd.java	0.00%	14 Missing :warning:
...che/cloudstack/api/response/AlertTypeResponse.java	0.00%	11 Missing :warning:
ui/src/config/section/compute.js	0.00%	5 Missing :warning:
ui/src/config/section/network.js	0.00%	4 Missing :warning:
ui/src/views/network/PublicIpResource.vue	0.00%	4 Missing :warning:
ui/src/config/section/infra/ilbvms.js	0.00%	3 Missing :warning:
...ommand/admin/acl/project/DeleteProjectRoleCmd.java	0.00%	2 Missing :warning:
...in/acl/project/DeleteProjectRolePermissionCmd.java	0.00%	2 Missing :warning:
... and 5 more

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8630      +/-   ##
============================================
+ Coverage     29.99%   30.90%   +0.91%     
- Complexity    33085    34278    +1193     
============================================
  Files          5346     5356      +10     
  Lines        375445   376186     +741     
  Branches      54605    54700      +95     
============================================
+ Hits         112622   116278    +3656     
+ Misses       247938   244611    -3327     
- Partials      14885    15297     +412

Flag	Coverage Δ
simulator-marvin-tests	`24.73% <40.35%> (+1.17%)`	:arrow_up:
uitests	`4.38% <0.00%> (-0.01%)`	:arrow_down:
unit-tests	`16.58% <0.00%> (+0.04%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Feb 08 '24 18:02 codecov[bot]

@blueorangutan package

Feb 08 '24 19:02 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Feb 08 '24 19:02 blueorangutan

@blueorangutan package

Feb 09 '24 09:02 kiranchavala

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Feb 09 '24 09:02 blueorangutan

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8609

Feb 09 '24 10:02 blueorangutan

@vishesh92 can you fix the packaging job failures.

Should this pointed to main branch or 4.19 ?

There is a linstor related exception

15:24:12 [INFO] ------------------------------------------------------------------------
15:24:12 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-storage-volume-linstor: Compilation failure
15:24:12 [ERROR] /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.20.0.0-SNAPSHOT/plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:[289,12] error: cannot find symbol
15:24:12 [ERROR]   symbol:   variable s_logger
15:24:12 [ERROR]   location: class LinstorStorageAdaptor
15:24:12 [ERROR] 
15:24:12 [ERROR] -> [Help 1]
15:24:12 [ERROR] 
15:24:12 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
15:24:12 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
15:24:12 [ERROR] 
15:24:12 [ERROR] For more information about the errors and possible solutions, please read the following articles:
15:24:12 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
15:24:12 [ERROR] 
15:24:12 [ERROR] After correcting the problems, you can resume the build with the command
15:24:12 [ERROR]   mvn <args> -rf :cloud-plugin-storage-volume-linstor
15:24:12 error: Bad exit status from /var/tmp/rpm-tmp.TSR0y4 (%build)
15:24:12

Feb 09 '24 10:02 kiranchavala

@vishesh92 can you fix the packaging job failures.

@kiranchavala there was an issue with main which is fixed now.

@blueorangutan package

Feb 09 '24 11:02 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Feb 09 '24 11:02 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8611

Feb 09 '24 12:02 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Feb 11 '24 07:02 github-actions[bot]

@blueorangutan package

Feb 11 '24 07:02 vishesh92

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Feb 11 '24 08:02 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8623

Feb 11 '24 09:02 blueorangutan

@blueorangutan ui

Feb 11 '24 09:02 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Feb 11 '24 09:02 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8630 (QA-JID-275)

Feb 11 '24 09:02 blueorangutan

@blueorangutan ui

Feb 12 '24 10:02 vishesh92

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Feb 12 '24 10:02 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8630 (QA-JID-277)

Feb 12 '24 10:02 blueorangutan

@vishesh92 I don't thiink we can test this with UI alone, can we?

Feb 12 '24 10:02 DaanHoogland

@blueorangutan test alma9 kvm-alma9

Feb 12 '24 10:02 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

Feb 12 '24 10:02 blueorangutan

@vishesh92 I don't thiink we can test this with UI alone, can we?

We can test majority of changes with UI alone.

The changes I have done in the MS are to add api resource type & id to certain commands which will make the events for those commands to show up in the UI.

Feb 12 '24 11:02 vishesh92

[SF] Trillian test result (tid-9166) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 1651 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8630-t9166-kvm-alma9.zip Smoke tests completed. 7 look OK, 122 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Test File
runTest	`Error`	test_2fa.py
runTest	`Error`	test_diagnostics.py
runTest	`Error`	test_accounts.py
runTest	`Error`	test_deploy_vm_extra_config_data.py
runTest	`Error`	test_affinity_groups_projects.py
runTest	`Error`	test_deploy_vms_with_varied_deploymentplanners.py
runTest	`Error`	test_affinity_groups.py
runTest	`Error`	test_annotations.py
runTest	`Error`	test_domain_disk_offerings.py
runTest	`Error`	test_async_job.py
runTest	`Error`	test_attach_multiple_volumes.py
runTest	`Error`	test_direct_download.py
runTest	`Error`	test_backup_recovery_dummy.py
runTest	`Error`	test_events_resource.py
runTest	`Error`	test_backup_recovery_veeam.py
runTest	`Error`	test_deploy_vm_iso.py
runTest	`Error`	test_certauthority_root.py
runTest	`Error`	test_disk_provisioning_types.py
runTest	`Error`	test_cluster_drs.py
runTest	`Error`	test_global_acls.py
runTest	`Error`	test_console_endpoint.py
runTest	`Error`	test_deploy_vm_with_userdata.py
runTest	`Error`	test_create_list_domain_account_project.py
runTest	`Error`	test_global_settings.py
runTest	`Error`	test_create_network.py
runTest	`Error`	test_deploy_vgpu_enabled_vm.py
runTest	`Error`	test_disk_offerings.py
runTest	`Error`	test_guest_os.py
runTest	`Error`	test_deploy_virtio_scsi_vm.py
runTest	`Error`	test_deploy_vm_iso_uefi.py
runTest	`Error`	test_guest_vlan_range.py
runTest	`Error`	test_deploy_vm_root_resize.py
runTest	`Error`	test_deploy_vms_in_parallel.py
runTest	`Error`	test_domain_network_offerings.py
runTest	`Error`	test_domain_service_offerings.py
runTest	`Error`	test_domain_vpc_offerings.py
runTest	`Error`	test_enable_account_settings_for_domain.py
runTest	`Error`	test_gateway_on_shared_networks.py
runTest	`Error`	test_host_control_state.py
runTest	`Error`	test_hostha_simulator.py
runTest	`Error`	test_host_ping.py
runTest	`Error`	test_image_store_object_migration.py
runTest	`Error`	test_internal_lb.py
runTest	`Error`	test_ipv6_infra.py
runTest	`Error`	test_iso.py
runTest	`Error`	test_kubernetes_clusters.py
runTest	`Error`	test_kubernetes_supported_versions.py
runTest	`Error`	test_list_accounts.py
runTest	`Error`	test_list_disk_offerings.py
runTest	`Error`	test_over_provisioning.py
runTest	`Error`	test_list_domains.py
runTest	`Error`	test_list_hosts.py
runTest	`Error`	test_nonstrict_affinity_group.py
runTest	`Error`	test_list_ids_parameter.py
runTest	`Error`	test_list_service_offerings.py
runTest	`Error`	test_list_storage_pools.py
runTest	`Error`	test_list_volumes.py
runTest	`Error`	test_password_server.py
runTest	`Error`	test_loadbalance.py
runTest	`Error`	test_login.py
runTest	`Error`	test_metrics_api.py
runTest	`Error`	test_migration.py
runTest	`Error`	test_multipleips_per_nic.py
runTest	`Error`	test_nested_virtualization.py
runTest	`Error`	test_network_acl.py
runTest	`Error`	test_portable_publicip.py
runTest	`Error`	test_network_ipv6.py
runTest	`Error`	test_outofbandmanagement.py
runTest	`Error`	test_network_permissions.py
runTest	`Error`	test_network.py
runTest	`Error`	test_nic_adapter_type.py
runTest	`Error`	test_nic.py
runTest	`Error`	test_non_contigiousvlan.py
runTest	`Error`	test_outofbandmanagement_nestedplugin.py
runTest	`Error`	test_persistent_network.py
runTest	`Error`	test_portforwardingrules.py
runTest	`Error`	test_primary_storage.py
runTest	`Error`	test_privategw_acl_ovs_gre.py
runTest	`Error`	test_privategw_acl.py
runTest	`Error`	test_projects.py
runTest	`Error`	test_public_ip_range.py
runTest	`Error`	test_pvlan.py
runTest	`Error`	test_quarantined_ips.py
runTest	`Error`	test_regions.py
runTest	`Error`	test_register_userdata.py
runTest	`Error`	test_volumes.py
runTest	`Error`	test_reset_configuration_settings.py
runTest	`Error`	test_reset_vm_on_reboot.py
runTest	`Error`	test_vm_life_cycle.py
runTest	`Error`	test_resource_accounting.py
runTest	`Error`	test_resource_detail.py
runTest	`Error`	test_vm_schedule.py
runTest	`Error`	test_router_dhcphosts.py
runTest	`Error`	test_router_dns.py
runTest	`Error`	test_router_dnsservice.py
runTest	`Error`	test_vm_deployment_planner.py
runTest	`Error`	test_routers_iptables_default_policy.py
runTest	`Error`	test_routers_network_ops.py
runTest	`Error`	test_routers.py
runTest	`Error`	test_vm_snapshot_kvm.py
runTest	`Error`	test_safe_shutdown.py
runTest	`Error`	test_scale_vm.py
runTest	`Error`	test_secondary_storage.py
runTest	`Error`	test_service_offerings.py
runTest	`Error`	test_vm_snapshots.py
runTest	`Error`	test_set_sourcenat.py
runTest	`Error`	test_vpc_ipv6.py
runTest	`Error`	test_snapshots.py
runTest	`Error`	test_ssvm.py
runTest	`Error`	test_storage_policy.py
runTest	`Error`	test_templates.py
runTest	`Error`	test_update_security_group.py
runTest	`Error`	test_usage_events.py
runTest	`Error`	test_usage.py
runTest	`Error`	test_vnf_templates.py
runTest	`Error`	test_vm_autoscaling.py
runTest	`Error`	test_vm_lifecycle_unmanage_import.py
runTest	`Error`	test_vpc_redundant.py
runTest	`Error`	test_vpc_router_nics.py
runTest	`Error`	test_vpc_vpn.py
runTest	`Error`	test_host_maintenance.py
runTest	`Error`	test_hostha_kvm.py

Feb 12 '24 11:02 blueorangutan

@blueorangutan test alma9 kvm-alma9

Feb 12 '24 19:02 vishesh92

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

Feb 12 '24 19:02 blueorangutan

[SF] Trillian test result (tid-9183) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 48789 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8630-t9183-kvm-alma9.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

Feb 13 '24 09:02 blueorangutan

@blueorangutan test alma9 kvm-alma9 keepEnv

Feb 13 '24 10:02 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

Feb 13 '24 10:02 blueorangutan

cloudstack cloudstack copied to clipboard

UI Fixes: allow filtering on alertype in UI & add events tab

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Codecov Report

cloudstack
cloudstack copied to clipboard