cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Don't allow host (KVM) addition without PowerFlex SDC installed/connected

Open sureshanaparti opened this issue 1 year ago • 5 comments

Description

This PR fails to add host (KVM) without PowerFlex SDC installed/connected (when PowerFlex storage pool exists as primary store and host fails to connect).

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Manually tested the host addition without SDC installation in one of the hosts.

sureshanaparti avatar Feb 08 '24 13:02 sureshanaparti

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Feb 08 '24 13:02 github-actions[bot]

@blueorangutan package

sureshanaparti avatar Feb 08 '24 14:02 sureshanaparti

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.38%. Comparing base (49cecae) to head (df822a1). Report is 286 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #8628       +/-   ##
============================================
- Coverage     30.37%   4.38%   -25.99%     
============================================
  Files          5352     361     -4991     
  Lines        374419   28706   -345713     
  Branches      54609    5004    -49605     
============================================
- Hits         113719    1258   -112461     
+ Misses       245523   27309   -218214     
+ Partials      15177     139    -15038     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.38% <ø> (-0.01%) :arrow_down:
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 08 '24 14:02 codecov[bot]

@sureshanaparti since 4.19 is already cut, can we change the base branch to 4.19 for this PR ?

harikrishna-patnala avatar Feb 09 '24 11:02 harikrishna-patnala

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar May 30 '24 14:05 github-actions[bot]