cloudstack
cloudstack copied to clipboard
vpc: create vpc tiers with dns server of vpc instead of zone
Description
This PR fixes #8598
with this change
root@r-575-VM:~# cat /etc/dnsmasq.d/cloud.conf
dhcp-hostsfile=/etc/dhcphosts.txt
listen-address=127.0.0.1,172.17.1.1,172.17.2.1,172.17.3.1
dhcp-range=set:interface-eth2-0,172.17.1.1,static
dhcp-option=tag:interface-eth2-0,15,cs2cloud.internal
dhcp-option=tag:interface-eth2-0,6,172.17.1.1,10.0.32.1,8.8.8.8
dhcp-option=tag:interface-eth2-0,3,172.17.1.1
dhcp-option=eth2,26,1500
dhcp-option=tag:interface-eth2-0,1,255.255.255.0
dhcp-range=set:interface-eth3-1,172.17.2.1,static
dhcp-option=tag:interface-eth3-1,15,cs2cloud.internal
dhcp-option=tag:interface-eth3-1,6,172.17.2.1,8.8.8.8,1.1.1.1
dhcp-option=tag:interface-eth3-1,3,172.17.2.1
dhcp-option=eth3,26,1500
dhcp-option=tag:interface-eth3-1,1,255.255.255.0
dhcp-range=set:interface-eth4-2,172.17.3.1,static
dhcp-option=tag:interface-eth4-2,15,cs2cloud.internal
dhcp-option=tag:interface-eth4-2,6,172.17.3.1,8.8.8.8,1.1.1.1
dhcp-option=tag:interface-eth4-2,3,172.17.3.1
dhcp-option=eth4,26,1500
dhcp-option=tag:interface-eth4-2,1,255.255.255.0
root@r-575-VM:~#
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 30.90%. Comparing base (
0d36098) to head (19745c9). Report is 63 commits behind head on 4.19.
| Files | Patch % | Lines |
|---|---|---|
| .../main/java/com/cloud/network/NetworkModelImpl.java | 75.00% | 0 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #8621 +/- ##
============================================
+ Coverage 30.75% 30.90% +0.14%
- Complexity 33964 34164 +200
============================================
Files 5346 5346
Lines 375435 375443 +8
Branches 54603 54607 +4
============================================
+ Hits 115460 116022 +562
+ Misses 244742 244152 -590
- Partials 15233 15269 +36
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 24.75% <50.00%> (+0.24%) |
:arrow_up: |
| uitests | 4.39% <ø> (ø) |
|
| unit-tests | 16.54% <50.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8910
@blueorangutan test
@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-9444) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50614 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8621-t9444-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_02_trigger_shutdown | Failure |
336.67 | test_safe_shutdown.py |
this has been merged into main branch as part of #7919 it has been verified