cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

NSX: Support ACL Rules re-ordering in NSX

Open Pearl1594 opened this issue 1 year ago • 2 comments
trafficstars

Description

This PR...

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 avatar Feb 06 '24 17:02 Pearl1594

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (09636cf) 15.86% compared to head (79b1490) 15.86%. Report is 3 commits behind head on nsx-integration.

Files Patch % Lines
...java/org/apache/cloudstack/service/NsxElement.java 42.85% 15 Missing and 1 partial :warning:
...a/com/cloud/network/vpc/NetworkACLManagerImpl.java 0.00% 8 Missing :warning:
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java 46.66% 7 Missing and 1 partial :warning:
...com/cloud/network/element/BigSwitchBcfElement.java 0.00% 1 Missing :warning:
...rk/contrail/management/ContrailVpcElementImpl.java 0.00% 1 Missing :warning:
...cloud/network/element/VpcVirtualRouterElement.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@                  Coverage Diff                  @@
##             nsx-integration    #8618      +/-   ##
=====================================================
- Coverage              15.86%   15.86%   -0.01%     
+ Complexity             16011    16010       -1     
=====================================================
  Files                   5155     5155              
  Lines                 363466   363502      +36     
  Branches               53192    53200       +8     
=====================================================
- Hits                   57658    57655       -3     
- Misses                299000   299038      +38     
- Partials                6808     6809       +1     
Flag Coverage Δ
uitests 4.36% <ø> (ø)
unit-tests 16.85% <35.18%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 18:02 codecov[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Feb 07 '24 05:02 github-actions[bot]

Already present in #7919

Pearl1594 avatar Jun 05 '24 16:06 Pearl1594