cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

removing the usage of volumeFreeze StorPool API call

Open slavkap opened this issue 1 year ago • 9 comments

Description

Deprecate the usage of the volumeFreeze API call.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

slavkap avatar Jan 30 '24 10:01 slavkap

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 23.10%. Comparing base (8f6721e) to head (23e3f20).

Files Patch % Lines
...tastore/driver/StorPoolPrimaryDataStoreDriver.java 0.00% 36 Missing :warning:
...ack/storage/motion/StorPoolDataMotionStrategy.java 0.00% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8575      +/-   ##
============================================
- Coverage     30.90%   23.10%   -7.80%     
+ Complexity    33382    23318   -10064     
============================================
  Files          5355     5219     -136     
  Lines        375727   353392   -22335     
  Branches      54915    50877    -4038     
============================================
- Hits         116109    81663   -34446     
- Misses       244219   259918   +15699     
+ Partials      15399    11811    -3588     
Flag Coverage Δ
simulator-marvin-tests 24.77% <0.00%> (+0.01%) :arrow_up:
uitests 4.36% <ø> (ø)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 11:01 codecov[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Feb 08 '24 13:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.17%. Comparing base (0ec7c72) to head (d099649). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #8575      +/-   ##
========================================
- Coverage   4.17%   4.17%   -0.01%     
========================================
  Files        371     371              
  Lines      30383   30407      +24     
  Branches    5374    5384      +10     
========================================
  Hits        1269    1269              
- Misses     28970   28994      +24     
  Partials     144     144              
Flag Coverage Δ
uitests 4.17% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 12 '24 07:04 codecov-commenter

Ping @slavkap Any further work on this?

sureshanaparti avatar Jun 27 '24 12:06 sureshanaparti

hey @sureshanaparti, no, I think all needed is included

slavkap avatar Jun 27 '24 13:06 slavkap

@blueorangutan package

sureshanaparti avatar Jun 27 '24 13:06 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 27 '24 13:06 blueorangutan

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10170

blueorangutan avatar Jun 27 '24 14:06 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 29 '24 02:06 github-actions[bot]