cloudstack
cloudstack copied to clipboard
apache
prevent duplicate ip table rules in SSVM
Description
This PR...
Fixes: #8061
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
might become more than minor on long running ssvms
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 13.17%. Comparing base (
0b080cf) to head (0d50cba).
Additional details and impacted files
@@ Coverage Diff @@
## 4.18 #8530 +/- ##
=========================================
Coverage 13.17% 13.17%
Complexity 9204 9204
=========================================
Files 2724 2724
Lines 258137 258137
Branches 40235 40235
=========================================
Hits 33998 33998
Misses 219830 219830
Partials 4309 4309
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.
Project coverage is 12.23%. Comparing base (
5c9d79e) to head (24cb34c). Report is 6 commits behind head on 4.18.
Additional details and impacted files
@@ Coverage Diff @@
## 4.18 #8530 +/- ##
============================================
- Coverage 12.24% 12.23% -0.01%
+ Complexity 9291 9290 -1
============================================
Files 4698 4699 +1
Lines 414259 414277 +18
Branches 52267 52888 +621
============================================
- Hits 50707 50706 -1
- Misses 357251 357271 +20
+ Partials 6301 6300 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 12.23% <12.24%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9847
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9860
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9881
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9902
[SF] Trillian test result (tid-10417) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44990 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8530-t10417-kvm-rocky8.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_migrate_VM_and_root_volume | Error |
88.05 | test_vm_life_cycle.py |
| test_02_migrate_VM_with_two_data_disks | Error |
55.20 | test_vm_life_cycle.py |
| test_08_migrate_vm | Error |
0.07 | test_vm_life_cycle.py |
[SF] Trillian test result (tid-10417) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44990 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8530-t10417-kvm-rocky8.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test Result Time (s) Test File test_01_migrate_VM_and_root_volume
Error88.05 test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disksError55.20 test_vm_life_cycle.py test_08_migrate_vmError0.07 test_vm_life_cycle.py
The failures are due to a host being in connecting state, which has not to do with the SSVM, so I consider them unrelated.
The failures are due to a host being in connecting state, which has not to do with the SSVM, so I consider them unrelated.
a side-note, I have faced the issue frequently, a random node (among 3) is stuck at Connecting state. It comes normal after 3600 seconds. the error log
2024-06-10T09:30:54,046 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentConnectTaskPool-35:[ctx-d47a6aa2]) (logid:8d018ce9) Failed to handle host connection: com.cloud.exception.ConnectionException: Unable to acquire lock on host 9c8f74c5-17aa-46f3-9b65-b905520b2879
at com.cloud.agent.manager.AgentManagerImpl.sendReadyAndGetAttache(AgentManagerImpl.java:1127)
at com.cloud.agent.manager.AgentManagerImpl.handleConnectedAgent(AgentManagerImpl.java:1140)
I think it deserves an investigation. cc @vishesh92 @DaanHoogland