cloudstack
cloudstack copied to clipboard
apache
server: apply rules when VR of Domain VPC is recreated
Description
After re-creating a VR from a domain VPC, ACS will not apply static nat, port forward and load balancer rules to IPs that are not associated to the account that owns the VPC. An adjustment was made to make sure that these rules are applied for all IPs when performing the following procedures:
-
VR restart
-
VPC restart
-
VPC restart with cleanup
-
recreate VR when health-check fails
-
recreate VR on failover
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
How Has This Been Tested?
In a local lab, I performed the procedures listed in the description and verified that after applying the changes, the IPs owned by accounts different than the VPC owner were having their rules applied accordingly.
Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 30.75%. Comparing base (
a15b706) to head (77aa9b2). Report is 389 commits behind head on 4.19.
| Files | Patch % | Lines |
|---|---|---|
| ...ork/router/VirtualNetworkApplianceManagerImpl.java | 66.66% | 0 Missing and 1 partial :warning: |
| .../router/VpcVirtualNetworkApplianceManagerImpl.java | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.19 #8354 +/- ##
============================================
+ Coverage 22.25% 30.75% +8.49%
- Complexity 22439 33065 +10626
============================================
Files 5117 5353 +236
Lines 346819 374603 +27784
Branches 49790 54634 +4844
============================================
+ Hits 77190 115196 +38006
+ Misses 258466 244117 -14349
- Partials 11163 15290 +4127
| Flag | Coverage Δ | |
|---|---|---|
| simulator-marvin-tests | 24.59% <50.00%> (+0.76%) |
:arrow_up: |
| uitests | 4.38% <ø> (-0.07%) |
:arrow_down: |
| unit-tests | 16.44% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8051
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-8599) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 61614 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8354-t8599-kvm-centos7.zip Smoke tests completed. 117 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_08_migrate_vm | Error |
46.09 | test_vm_life_cycle.py |
| test_01_verify_ipv6_vpc | Error |
603.86 | test_vpc_ipv6.py |
| test_05_rvpc_multi_tiers | Failure |
503.24 | test_vpc_redundant.py |
| test_05_rvpc_multi_tiers | Error |
503.26 | test_vpc_redundant.py |
| test_01_redundant_vpc_site2site_vpn | Failure |
579.31 | test_vpc_vpn.py |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8685
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian test result (tid-9264) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45943 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8354-t9264-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_02_upgrade_kubernetes_cluster | Failure |
236.44 | test_kubernetes_clusters.py |
@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre
Is there any pending concern regarding this or can we proceed with the merge?
@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre
Is there any pending concern regarding this or can we proceed with the merge?
@GaOrtiga can you ask someone to test it, share the test steps and results ?
@DaanHoogland @GutoVeronezi @shwstppr @JoaoJandre Is there any pending concern regarding this or can we proceed with the merge?
@GaOrtiga can you ask someone to test it, share the test steps and results ?
Ping @GaOrtiga Any update on the testing and results?
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10142
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10146
Ping @GaOrtiga Any further update?
No updates, just needs testing, I will check if someone can test and post results.
@GaOrtiga I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ). can you please add the UI changes and create a doc PR ?
@GaOrtiga I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ). can you please add the UI changes and create a doc PR ?
@weizhouapache Thank you for testing. Yes I will create the doc PR.
@GaOrtiga I am trying to test this feature. However, I cannot find any UI/doc change for the domain VPC (#7153 ). can you please add the UI changes and create a doc PR ?
@weizhouapache Thank you for testing. Yes I will create the doc PR.
Hi @GaOrtiga Please update the doc PR reference here once it is ready. Thanks.
@weizhouapache @sureshanaparti Link for the doc PR: https://github.com/apache/cloudstack-documentation/pull/410