cloudstack
cloudstack copied to clipboard
Logging improvements on migration in the VmwareResource
Description
This PR,..
Fixes: #8291
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.
Comparison is base (
e47a910) 13.16% compared to head (f99ff13) 13.16%.
| Files | Patch % | Lines |
|---|---|---|
| ...oud/hypervisor/vmware/resource/VmwareResource.java | 0.00% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.18 #8300 +/- ##
============================================
- Coverage 13.16% 13.16% -0.01%
Complexity 9203 9203
============================================
Files 2724 2724
Lines 258120 258127 +7
Branches 40231 40234 +3
============================================
Hits 33989 33989
- Misses 219823 219830 +7
Partials 4308 4308
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@blueorangutan package
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
@blueorangutan package
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8057
@blueorangutan test alma9 vmware-70u3
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests
[SF] Trillian test result (tid-8618) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 47084 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t8618-vmware-70u3.zip Smoke tests completed. 106 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_05_ping_in_cpvm_success | Error |
1.12 | test_diagnostics.py |
| test_06_ping_in_cpvm_failure | Error |
1.11 | test_diagnostics.py |
| test_12_traceroute_in_cpvm | Error |
1.11 | test_diagnostics.py |
| test_17_retrieve_cpvm_default_files | Error |
1.11 | test_diagnostics.py |
| test_18_retrieve_cpvm_single_file | Error |
1.12 | test_diagnostics.py |
| test_01_add_primary_storage_disabled_host | Error |
36.25 | test_primary_storage.py |
| test_01_non_strict_host_anti_affinity | Failure |
147.21 | test_nonstrict_affinity_group.py |
| test_02_non_strict_host_affinity | Error |
107.25 | test_nonstrict_affinity_group.py |
@blueorangutan package
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8518
@blueorangutan test alma9 vmware-70u3
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests
[SF] Trillian test result (tid-9092) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 49798 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8300-t9092-vmware-70u3.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
clgtm. Just a small suggestion.
Not ready for merge, if changes are made and not packages/tested @blueorangutan package
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8636
@blueorangutan package
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8641
Not ready for merge, if changes are made and not packages/tested @blueorangutan package
the changes on that last commit were only textual and the GHA for build was succesful. I think it was ready for merge.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled withthe changes on that last commit were only textual and the GHA for build was succesful. I think it was ready for merge. SystemVM template(s). I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8643
@blueorangutan test
@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
[SF] Trillian Build Failed (tid-9206)
@blueorangutan test
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests