cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

on forName validate packages of classes to load

Open DaanHoogland opened this issue 2 years ago • 3 comments

Description

This PR...

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland avatar Nov 28 '23 15:11 DaanHoogland

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3bb318b) 13.13% compared to head (b3965d3) 13.11%.

:exclamation: Current head b3965d3 differs from pull request most recent head e5e91a2. Consider uploading reports for the commit e5e91a2 to get more accurate results

Files Patch % Lines
...c/main/java/com/cloud/api/ApiSerializerHelper.java 45.00% 6 Missing and 5 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.18    #8277      +/-   ##
============================================
- Coverage     13.13%   13.11%   -0.02%     
+ Complexity     9143     9135       -8     
============================================
  Files          2720     2720              
  Lines        257717   257658      -59     
  Branches      40176    40173       -3     
============================================
- Hits          33843    33804      -39     
+ Misses       219583   219561      -22     
- Partials       4291     4293       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 15:11 codecov[bot]

Codecov Report

:x: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 16.18%. Comparing base (e4414d1) to head (3199374).

Files with missing lines Patch % Lines
...c/main/java/com/cloud/api/ApiSerializerHelper.java 52.00% 7 Missing and 5 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20    #8277      +/-   ##
============================================
- Coverage     16.18%   16.18%   -0.01%     
- Complexity    13300    13302       +2     
============================================
  Files          5657     5657              
  Lines        498478   498488      +10     
  Branches      60501    60503       +2     
============================================
- Hits          80668    80661       -7     
- Misses       408827   408840      +13     
- Partials       8983     8987       +4     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.03% <52.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Apr 19 '24 09:04 codecov-commenter

@blueorangutan package

DaanHoogland avatar Dec 08 '25 15:12 DaanHoogland