cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

NSX integration

Open Pearl1594 opened this issue 1 year ago • 301 comments

Description

This PR adds support for VMware NSX on CloudStack

Documentation: https://github.com/apache/cloudstack-documentation/pull/378

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [x] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Testing on VMware NSX 4.1, CloudStack env vCenter 7.0

Pearl1594 avatar Aug 28 '23 19:08 Pearl1594

Codecov Report

Attention: Patch coverage is 41.89028% with 1949 lines in your changes are missing coverage. Please review.

Project coverage is 31.31%. Comparing base (3baa45b) to head (2187fdd). Report is 19 commits behind head on main.

Files Patch % Lines
...va/org/apache/cloudstack/service/NsxApiClient.java 6.65% 614 Missing and 3 partials :warning:
...java/org/apache/cloudstack/service/NsxElement.java 58.57% 117 Missing and 40 partials :warning:
...va/org/apache/cloudstack/resource/NsxResource.java 49.80% 107 Missing and 22 partials :warning:
...apache/cloudstack/service/NsxGuestNetworkGuru.java 42.10% 56 Missing and 32 partials :warning:
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue 0.00% 57 Missing :warning:
ui/src/views/offering/AddNetworkOffering.vue 0.00% 52 Missing :warning:
.../org/apache/cloudstack/service/NsxServiceImpl.java 44.70% 43 Missing and 4 partials :warning:
...ain/java/com/cloud/network/NetworkServiceImpl.java 38.15% 40 Missing and 7 partials :warning:
ui/src/views/offering/AddVpcOffering.vue 0.00% 45 Missing :warning:
...tack/engine/orchestration/NetworkOrchestrator.java 36.66% 28 Missing and 10 partials :warning:
... and 87 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7919      +/-   ##
============================================
+ Coverage     29.92%   31.31%   +1.39%     
- Complexity    32240    34740    +2500     
============================================
  Files          5355     5397      +42     
  Lines        375771   386030   +10259     
  Branches      54912    57944    +3032     
============================================
+ Hits         112455   120903    +8448     
- Misses       248321   249075     +754     
- Partials      14995    16052    +1057
Flag Coverage Δ
simulator-marvin-tests 24.97% <13.78%> (+1.56%) :arrow_up:
uitests 4.33% <0.44%> (-0.04%) :arrow_down:
unit-tests 16.96% <35.88%> (+0.37%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '23 20:08 codecov[bot]

@blueorangutan package

nvazquez avatar Sep 19 '23 11:09 nvazquez

@nvazquez a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 19 '23 11:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7063

blueorangutan avatar Sep 19 '23 12:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 21 '23 23:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 21 '23 23:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 22 '23 13:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 22 '23 13:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7085

blueorangutan avatar Sep 22 '23 14:09 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Sep 25 '23 08:09 github-actions[bot]

@blueorangutan package

Pearl1594 avatar Sep 25 '23 12:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 25 '23 12:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7096

blueorangutan avatar Sep 25 '23 13:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 25 '23 16:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 25 '23 16:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7101

blueorangutan avatar Sep 25 '23 17:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 26 '23 13:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 26 '23 13:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 26 '23 13:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 26 '23 13:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7112

blueorangutan avatar Sep 26 '23 14:09 blueorangutan

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 22 Code Smells

0.8% 0.8% Coverage
6.2% 6.2% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Sep 26 '23 14:09 sonarqubecloud[bot]

@blueorangutan package

Pearl1594 avatar Sep 26 '23 19:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 26 '23 19:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7114

blueorangutan avatar Sep 26 '23 20:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 27 '23 11:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 27 '23 11:09 blueorangutan

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7124

blueorangutan avatar Sep 27 '23 12:09 blueorangutan

@blueorangutan package

Pearl1594 avatar Sep 27 '23 15:09 Pearl1594

@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 27 '23 15:09 blueorangutan